Add unit test for convert_notebook_to_script

Author: pont-us

test/test_core.py

@@ -128,8 +128,30 @@ def test_script_creator_init_with_parameters():
         "parameter_2": (str, "default value"),
     }
 
+
 def test_script_creator_init_no_parameters():
     script_creator = ScriptCreator(
         pathlib.Path(__file__).parent / "data" / "noparamtest.ipynb"
     )
     assert script_creator.nb_params.params == {}
+
+
+@pytest.mark.parametrize("clear", [True, False])
+def test_script_creator_convert_notebook_to_script(tmp_path, clear):
+    (output_dir := tmp_path / "output").mkdir()
+    extraneous_filename = "foo"
+    (output_dir / extraneous_filename).touch()
+    script_creator = ScriptCreator(
+        pathlib.Path(__file__).parent / "data" / "paramtest.ipynb"
+    )
+    script_creator.convert_notebook_to_script(output_dir, clear)
+    filenames = {
+        "user_code.py",
+        "execute.py",
+        "parameters.py",
+        "parameters.yaml",
+        "util.py",
+    } | (set() if clear else {extraneous_filename})
+    expected = {output_dir / f for f in filenames}
+    assert set(output_dir.iterdir()) == expected
+    # TODO test execution as well?

xcengine/core.py

@@ -54,8 +54,8 @@ def convert_notebook_to_script(
         (body, resources) = exporter.from_notebook_node(self.notebook)
         with open(output_dir / "user_code.py", "w") as fh:
             fh.write(
-                    "import unittest.mock\n"
-                    "get_ipython = unittest.mock.MagicMock\n"
+                "import unittest.mock\n"
+                "get_ipython = unittest.mock.MagicMock\n"
             )
             fh.write(body)
         parent_dir = pathlib.Path(__file__).parent
@@ -84,8 +84,7 @@ def process_params_cell(self) -> None:
             # turns them into no-ops
             setup_code = (
                 "import unittest.mock\n"
-                "get_ipython = unittest.mock.MagicMock\n"
-                + setup_code
+                "get_ipython = unittest.mock.MagicMock\n" + setup_code
             )
             params_node = nbformat.from_dict(self.notebook)
             params_node.cells = [params_node.cells[params_cell_index]]