Class 0x19 clip rectangle support for 2d blitting operations is not implemented

[abaire]

Bug Description

xemu does not yet implement handling for graphics class 0x19 clip rectangles, leading to incorrect behavior when 0x9F blits use non-fullscreen clip rectangles.

So far all of the cases in retail titles that I've seen have full screen clip rectangles so this may be rarely used in practice.

Expected Behavior

See the image blit clip tests in the pgraph tester; expected results: https://abaire.github.io/nxdk_pgraph_tests_golden_results/results/Image_blit/index.html

xemu Version

All versions

System Information

N/A. Affects all systems.

Additional Context

No response

[abaire]

nit: @Triticum0 I don't think documentation is the right tag for this one.

I believe the overarching goal of the project is to accurately emulate the Xbox (including the nv2a) so this is technically a bug, just not one that feels urgent to fix given that it may not manifest in XDK/DirectX produced binaries (or it may, but is uncommon enough that we haven't run into it yet).

I do think this should be labeled as graphics, however.

[Triticum0]

sorry, bit of an overreach.