Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass Effect 2 demo package crashes STFS handling code #1371

Open
gibbed opened this issue May 11, 2019 · 1 comment
Open

Mass Effect 2 demo package crashes STFS handling code #1371

gibbed opened this issue May 11, 2019 · 1 comment
Assignees
Labels

Comments

@gibbed
Copy link
Member

gibbed commented May 11, 2019

xenia-vfs-dump.exe!xe::load_and_swap<unsigned char>(const void * mem) Line 236
	at src\xenia\base\memory.h(236)
xenia-vfs-dump.exe!xe::vfs::StfsContainerDevice::GetBlockHash(const unsigned char * map_ptr, unsigned int block_index, unsigned int table_offset) Line 606
	at src\xenia\vfs\devices\stfs_container_device.cc(606)
xenia-vfs-dump.exe!xe::vfs::StfsContainerDevice::ReadSTFS() Line 542
	at src\xenia\vfs\devices\stfs_container_device.cc(542)
xenia-vfs-dump.exe!xe::vfs::StfsContainerDevice::Initialize() Line 85
	at src\xenia\vfs\devices\stfs_container_device.cc(85)
xenia-vfs-dump.exe!xe::vfs::vfs_dump_main(const std::vector<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,std::allocator<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> > > > & args) Line 35
	at src\xenia\vfs\vfs_dump.cc(35)

src/xenia/vfs/devices/stfs_container_device.cc#L606
src/xenia/vfs/devices/stfs_container_device.cc#L542
src/xenia/vfs/devices/stfs_container_device.cc#L85

When parsing all file information, eventually encounters an invalid block for the file Opening_End_Seq.bik, which is a fairly large file.

This was not broken with the merge of #1254, problem existed prior.
Could be related to #617.

@Gliniak
Copy link
Member

Gliniak commented May 22, 2024

Seems to be fixed with: #2216

It still triggers assertions, however game works.

On master probably crashes only due to broken log in stfs code and should also trigger the same assertions as that PR is mostly about moving code instead of modyfing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants