[bug] Macos can't add word to favorite by shortcut in pop up window.

[laraws]

Describe the bug
I use command+c,c to search translate a word from clipboard, it pops up a small window. Then I try to use command+e to add this word to favorite, it doesn't work.

To Reproduce
Steps to reproduce the behavior:

1. use command+c,c to search translate a word from clipboard
2. use command+e to add this word to favorite

Screenshots

OS and software versions

Goldendict-ng 24.09.1.ca9dd133 at 2024-11-04T21:40:54Z
Qt 6.6.3 Clang 15.0.0 (clang-1500.3.9.4) macos darwin 22.6.0 arm64-little_endian-lp64
Flags: MAKE_ZIM_SUPPORT MAKE_CHINESE_CONVERSION_SUPPORT NO_TTS_SUPPORT no_ffmpeg_player

• OS: Macos 13.5 M1

Additional context
Add any other context about the problem here.

Please fix this bug, thank you.

[shenlebantongying]

Just for the record, no idea how much work is needed to fix this (the menu is in the .ui file instead of .cc).

There are two causes:

1. macOS, the system itself handles menu bar shortcuts.
   • Once a menu bar item have shortcut registered, macOS will handle the shortcut. From app's point of view, only the triggering of that menu item can be observed.
   • There is absolutely no way to do anything about this by the app or Qt.
2. macOS's menubar is associated with the whole app, instead of one window. So hiding the main window won't deactivate the menu bar.

When the popup windows show up, the menu bar will also show up, and the macOS's shortcut handling will handle shortcuts on the menu bar and the app cannot observe related key pressing in the popup window.

(Observed bug: When only popup shows up, press any shortcuts that conflicts with the menu bar, the menu bar will flash/highlight indicating that some item triggered.)

One of the proper fixes is deactivating the menu bar when the main window is hidden. (There are other ways).