Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac theme regular icons and large icon text are not fully displayed under macos #2044

Closed
liuchanghuaX1 opened this issue Dec 27, 2024 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@liuchanghuaX1
Copy link

image
image
image
版本为Goldendict-ng 24.11.0.f5ab68c at 2024-12-27T08:03:38Z
Qt 6.7.2 Clang 15.0.0 (clang-1500.3.9.4) macos darwin 24.2.0 arm64-little_endian-lp64
Flags: MAKE_ZIM_SUPPORT EPWING_SUPPORT MAKE_CHINESE_CONVERSION_SUPPORT no_ffmpeg_player
样式需要改变一下,字体太大了,无法完全显示。

@github-actions github-actions bot changed the title macos 下mac主题常规图标、大图标文字显示不全 Mac theme regular icons and large icon text are not fully displayed under macos Dec 27, 2024
@xiaoyifang xiaoyifang added the bug Something isn't working label Dec 28, 2024
Repository owner deleted a comment from github-actions bot Dec 28, 2024
Repository owner deleted a comment from github-actions bot Dec 28, 2024
@xiaoyifang
Copy link
Owner

Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically.

Please test this version https://github.com/xiaoyifang/goldendict-ng/releases/tag/v24.11.0-alpha.51cb0466

@liuchanghuaX1
Copy link
Author

麻烦测试下这个版本https://github.com/xiaoyifang/goldendict-ng/releases/tag/v24.11.0-alpha.51cb0466

image
image
Goldendict-ng 24.11.0.51cb046 at 2024-12-28T01:16:05Z
Qt 6.7.2 Clang 15.0.0 (clang-1500.3.9.4) macos darwin 24.2.0 arm64-little_endian-lp64
Flags: MAKE_ZIM_SUPPORT EPWING_SUPPORT MAKE_CHINESE_CONVERSION_SUPPORT no_ffmpeg_player
这个版本也没解决。

@xiaoyifang xiaoyifang self-assigned this Dec 28, 2024
@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Dec 29, 2024

In Qt's "macOS" theme, most of the widgets are real Cocoa/AppKit widgets under the hood. They have some oddities and lots of things cannot be changed. There is no obvious and reliable way to change some widgets' geometry.

(In fact, I never see a combo box of different size in macOS. Cocoa/AppKit probably doesn't even have an API to change the size of the combo box, and Qt cannot do anything to it.)

For macOS, disabling the code that changes font sizes of combo boxes and the drop-down completers is probably the best thing to do.

@xiaoyifang
Copy link
Owner

xiaoyifang commented Dec 29, 2024

For macOS, disabling the code that changes font sizes of combo boxes and the drop-down completers is probably the best thing to do.

I'll try in another PR #2047

Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically.

The latest version of the font display is abnormal, and the entire panel layout is unbalanced.
Goldendict-ng 24.11.0.4b3d090 at 2024-12-29T11:43:54Z
Qt 6.7.2 Clang 15.0.0 (clang-1500.3.9.4) macos darwin 24.2.0 arm64-little_endian-lp64
Flags: MAKE_ZIM_SUPPORT EPWING_SUPPORT MAKE_CHINESE_CONVERSION_SUPPORT no_ffmpeg_player

Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically.

Uploading image.png…
The latest version of the font display is abnormal, and the entire panel layout is unbalanced.
Goldendict-ng 24.11.0.4b3d090 at 2024-12-29T11:43:54Z
Qt 6.7.2 Clang 15.0.0 (clang-1500.3.9.4) macos darwin 24.2.0 arm64-little_endian-lp64
Flags: MAKE_ZIM_SUPPORT EPWING_SUPPORT MAKE_CHINESE_CONVERSION_SUPPORT no_ffmpeg_player

@liuchanghuaX1
Copy link
Author

image
最新版,边缘仍然移除,右边大片空白不好看,建议直接居左,左右对称分布。
Goldendict-ng 24.11.0.542ff72 at 2025-01-02T10:00:12Z
Qt 6.7.2 Clang 15.0.0 (clang-1500.3.9.4) macos darwin 24.2.0 arm64-little_endian-lp64
Flags: MAKE_ZIM_SUPPORT EPWING_SUPPORT MAKE_CHINESE_CONVERSION_SUPPORT no_ffmpeg_player

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Bot detected the issue body's language is not English, translate it automatically.

image
In the latest version, the edges are still removed, and the large blank space on the right is unsightly. It is recommended to place it directly on the left and distribute it symmetrically on the left and right.
Goldendict-ng 24.11.0.542ff72 at 2025-01-02T10:00:12Z
Qt 6.7.2 Clang 15.0.0 (clang-1500.3.9.4) macos darwin 24.2.0 arm64-little_endian-lp64
Flags: MAKE_ZIM_SUPPORT EPWING_SUPPORT MAKE_CHINESE_CONVERSION_SUPPORT no_ffmpeg_player

Repository owner deleted a comment from github-actions bot Jan 4, 2025
@xiaoyifang
Copy link
Owner

handled in #2063

@liuchanghuaX1
Copy link
Author

handled in #2063

image
已经解决了。谢谢!

Copy link
Contributor

github-actions bot commented Jan 4, 2025

Bot detected the issue body's language is not English, translate it automatically.

handled in #2063

image
Already solved. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants