From ddfef05f118e77cdb80a1f5971f076a03d221cb1 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Thu, 17 Oct 2024 15:43:02 +0200 Subject: [PATCH] test: remove duplicate tests `test/parallel/test-dns-default-verbatim-false.js` is a duplicate of `test/parallel/test-dns-default-order-ipv4.js` and `test/parallel/test-dns-default-verbatim-true.js` is a duplicate of `test/parallel/test-dns-default-order-verbatim.js`. PR-URL: https://github.com/nodejs/node/pull/55393 Reviewed-By: Yagiz Nizipli Reviewed-By: Richard Lau Reviewed-By: Marco Ippolito Reviewed-By: Jake Yuesong Li --- .../test-dns-default-verbatim-false.js | 51 ------------------- .../test-dns-default-verbatim-true.js | 51 ------------------- 2 files changed, 102 deletions(-) delete mode 100644 test/parallel/test-dns-default-verbatim-false.js delete mode 100644 test/parallel/test-dns-default-verbatim-true.js diff --git a/test/parallel/test-dns-default-verbatim-false.js b/test/parallel/test-dns-default-verbatim-false.js deleted file mode 100644 index 76f6ef0bcabd82..00000000000000 --- a/test/parallel/test-dns-default-verbatim-false.js +++ /dev/null @@ -1,51 +0,0 @@ -// Flags: --expose-internals --dns-result-order=ipv4first -'use strict'; -const common = require('../common'); -const assert = require('assert'); -const { internalBinding } = require('internal/test/binding'); -const cares = internalBinding('cares_wrap'); -const { promisify } = require('util'); - -// Test that --dns-result-order=ipv4first works as expected. - -const originalGetaddrinfo = cares.getaddrinfo; -const calls = []; -cares.getaddrinfo = common.mustCallAtLeast((...args) => { - calls.push(args); - originalGetaddrinfo(...args); -}, 1); - -const dns = require('dns'); -const dnsPromises = dns.promises; - -let verbatim; - -// We want to test the parameter of verbatim only so that we -// ignore possible errors here. -function allowFailed(fn) { - return fn.catch((_err) => { - // - }); -} - -(async () => { - let callsLength = 0; - const checkParameter = (expected) => { - assert.strictEqual(calls.length, callsLength + 1); - verbatim = calls[callsLength][4]; - assert.strictEqual(verbatim, expected); - callsLength += 1; - }; - - await allowFailed(promisify(dns.lookup)('example.org')); - checkParameter(cares.DNS_ORDER_IPV4_FIRST); - - await allowFailed(dnsPromises.lookup('example.org')); - checkParameter(cares.DNS_ORDER_IPV4_FIRST); - - await allowFailed(promisify(dns.lookup)('example.org', {})); - checkParameter(cares.DNS_ORDER_IPV4_FIRST); - - await allowFailed(dnsPromises.lookup('example.org', {})); - checkParameter(cares.DNS_ORDER_IPV4_FIRST); -})().then(common.mustCall()); diff --git a/test/parallel/test-dns-default-verbatim-true.js b/test/parallel/test-dns-default-verbatim-true.js deleted file mode 100644 index dfa0640f446412..00000000000000 --- a/test/parallel/test-dns-default-verbatim-true.js +++ /dev/null @@ -1,51 +0,0 @@ -// Flags: --expose-internals --dns-result-order=verbatim -'use strict'; -const common = require('../common'); -const assert = require('assert'); -const { internalBinding } = require('internal/test/binding'); -const cares = internalBinding('cares_wrap'); -const { promisify } = require('util'); - -// Test that --dns-result-order=verbatim works as expected. - -const originalGetaddrinfo = cares.getaddrinfo; -const calls = []; -cares.getaddrinfo = common.mustCallAtLeast((...args) => { - calls.push(args); - originalGetaddrinfo(...args); -}, 1); - -const dns = require('dns'); -const dnsPromises = dns.promises; - -let verbatim; - -// We want to test the parameter of verbatim only so that we -// ignore possible errors here. -function allowFailed(fn) { - return fn.catch((_err) => { - // - }); -} - -(async () => { - let callsLength = 0; - const checkParameter = (expected) => { - assert.strictEqual(calls.length, callsLength + 1); - verbatim = calls[callsLength][4]; - assert.strictEqual(verbatim, expected); - callsLength += 1; - }; - - await allowFailed(promisify(dns.lookup)('example.org')); - checkParameter(cares.DNS_ORDER_VERBATIM); - - await allowFailed(dnsPromises.lookup('example.org')); - checkParameter(cares.DNS_ORDER_VERBATIM); - - await allowFailed(promisify(dns.lookup)('example.org', {})); - checkParameter(cares.DNS_ORDER_VERBATIM); - - await allowFailed(dnsPromises.lookup('example.org', {})); - checkParameter(cares.DNS_ORDER_VERBATIM); -})().then(common.mustCall());