Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Boost ICL and Interval to Boost xmake.lua #2795

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Added Boost ICL and Interval to Boost xmake.lua #2795

merged 1 commit into from
Nov 6, 2023

Conversation

Theramar
Copy link
Contributor

@Theramar Theramar commented Nov 5, 2023

@Theramar
Copy link
Contributor Author

Theramar commented Nov 5, 2023

I don't know what causes the failures

@waruqi waruqi merged commit ebc9322 into xmake-io:dev Nov 6, 2023
43 of 53 checks passed
@evanzd
Copy link

evanzd commented Nov 7, 2023

@Theramar @waruqi This PR has caused our project to not build correctly. Could you offer any guidance on resolving this issue?
we are using xmake version 2.7.9 with boost as one of our dependencies:

add_requires("boost 1.81.0", {system = false, configs = {all = true, multi = true}})

xmake -vvD output:

./b2 --prefix=/home/rnd/.xmake/packages/b/boost/1.81.0/a78f4cd0482541ddaa8865c0a26b654b --libdir=/home/rnd/.xmake/packages/b/boost/1.81.0/a78f4cd0482541ddaa8865c0a26b654b/lib -d2 -j3 --hash -q --layout=tagged-1.66 --user-config=user-config.jam -sNO_LZMA=1 -sNO_ZSTD=1 install threading=multi debug-symbols=off link=static variant=release runtime-debugging=off address-model=64 cxxflags=-std=c++14 cxxflags=-fPIC --with-fiber --with-coroutine --with-context --with-regex --with-system --with-container --with-exception --with-timer --with-atomic --with-graph --with-serialization --with-random --with-wave --with-date_time --with-locale --with-iostreams --with-icl --with-interval --with-program_options --with-test --with-chrono --with-contract --with-graph_parallel --with-json --with-log --with-thread --with-filesystem --with-math --with-mpi --with-nowide --with-python --with-stacktrace --with-type_erasure pch=off
error: wrong library name 'icl' in the --with-<library> option.

@Theramar
Copy link
Contributor Author

Theramar commented Nov 7, 2023

@evanzd I am not an expert... I would wait for @waruqi. In the meantime you could send us logs/install.txt and xmake output using -D (verbose diagnostics)

@evanzd
Copy link

evanzd commented Nov 7, 2023

We need to revert this commit because 'icl' and 'interval' are header-only libraries. You can verify my findings using the attached repository (use a clear environment without boost installed).
repo.tgz
build_log.txt

@waruqi
Copy link
Member

waruqi commented Nov 8, 2023

We need to revert this commit because 'icl' and 'interval' are header-only libraries. You can verify my findings using the attached repository (use a clear environment without boost installed). repo.tgz build_log.txt

right, we need not add them, I have reverted this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants