-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add node-addon-api package for linux #4505
Conversation
packages/n/node-addon-api/xmake.lua
Outdated
"https://github.com/nodejs/node-addon-api.git") | ||
add_versions("v8.0.0", "42424c5206b9d67b41af4fcff5d6e3cb22074168035a03b8467852938a281d47") | ||
|
||
add_deps("node", {kind = 'binary', system = true}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no this package in xmake-repo now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find it, removing system = true
gives me this error:
error: package(node) not found!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you should add node as package first. and add on_fetch
to find system node in node package at least. like opengl package.
@waruqi is the PR ready to be merged ? |
I wrote this package for node-addon-api as the project relies on their own build system (node-gyp) that I didn't want to use.
It only supports Linux for now as the
.gyp
files on their repository seem to indicate that platform specific steps are needed for Windows and Macos.