Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add on_fetch to binutils package #4636

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Conversation

enzalito
Copy link
Contributor

on_fetch("@linux", "@macosx", "@msys", function (package, opt)
if opt.system then
if package:is_binary() then
if package:find_tool("ld") then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check a few more tools, just checking ld doesn't guarantee that the binutils are already there, and we should exclude the windows platform.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check a few more tools, just checking ld doesn't guarantee that the binutils are already there

Ok I'll do that

and we should exclude the windows platform

Do you mean mysys ? I thought it would work because it's based on Arch, plus their website references a binutils package.

@waruqi waruqi merged commit 2a22475 into xmake-io:dev Jul 15, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find_package fails to find binutils on system
2 participants