definition is not used

[CheapMeow]

My complex project report error about definition is not be used, for example:

AppData\Local\.xmake\packages\g\glm\1.0.1\788496219b2d40629f92bac6907b6bba\include\glm\gtx\../gtx/component_wise.hpp(22): fatal error C1189: #error:  "GLM: GLM_GTX_component_wise is an experimental extension and may change in the future. Use #define GLM_ENABLE_EXPERIMENTAL before including it, if you really want to use it."

In this case, GLM_ENABLE_EXPERIMENTAL is not defined.

But i am sured that it is writed in xmake.lua.

So I create a new project, only one source file, and keep most of my xmake.lua code.

The only source file:

#include <glm/gtc/matrix_transform.hpp>
#include <glm/gtx/euler_angles.hpp>

void main_test()
{
    glm::quat rotation(1.0, 1.0, 1.0, 1.0);
    glm::vec3 euler = glm::eulerAngles(rotation);
}

The xmake.lua from my complex project

set_project("TestApp")

add_requires("vulkansdk")
-- add_requires("llvm") llvm isn't supported well now, so hard code dependency on env. TODO: write local package
add_requires("glm", {configs = {small = true}})
add_requires("glm", "glfw", "volk", "spirv-cross", "stb", "assimp")
add_requires("imgui docking", {configs = {glfw = true, vulkan = true}})

target("test_app", function()
    set_kind("static")
    add_files("src/**.cpp")
    add_includedirs("src")
    add_packages("glm", "glfw", "vulkansdk", "volk", "spirv-cross", "stb", "assimp", "imgui", {public = true})

    add_defines("ENGINE_ROOT_DIR=\"" .. os.projectdir() .. "\"", {public = true})
    
    add_defines("NOMINMAX", {public = true}) -- for std::numeric_limits<double>::min() and max()

    add_defines("GLM_ENABLE_EXPERIMENTAL", {public = true})   -- for GLM: GLM_GTX_component_wise
    add_defines("GLFW_INCLUDE_VULKAN", {public = true})
    add_defines("GLFW_EXPOSE_NATIVE_WIN32", {public = true}) -- TODO: Config by platform
    add_defines("VK_USE_PLATFORM_WIN32_KHR", {public = true}) -- TODO: Config by platform
    if is_mode("EditorDebug", "GameDebug") then
        add_defines("VKB_DEBUG", "VKB_VALIDATION_LAYERS", {public = true})
    end
    add_defines("VK_NO_PROTOTYPES", {public = true})
    add_defines("IMGUI_DEFINE_MATH_OPERATORS", {public = true})
end)

Then the minimum project build success.

I didn't simplify my xmake.lua. Because I want to show there is no more code to influent building.

By the way, I output the compile_command.json for my complex project, there is no GLM_ENABLE_EXPERIMENTAL. But in my minimum project, it shows up.

So the reason is double checked, the definition is not used when compiling. Why? Is anywhere my code affect the building?

[waruqi]

please provide full logs -vD

[CheapMeow]

error: @programdir\core\main.lua:329: @programdir\actions\build\main.lua:148: @programdir\modules\async\runjobs.lua:325: @programdir\modules\private\action\build\object.lua:91: @programdir\modules\core\tools\cl.lua:741: model.cpp
C:\Users\blizz\AppData\Local\.xmake\packages\g\glm\1.0.1\788496219b2d40629f92bac6907b6bba\include\glm\gtx\../gtx/component_wise.hpp(22): fatal error C1189: #error:  "GLM: GLM_GTX_component_wise is an experimental extension and may change in the future. Use #define GLM_ENABLE_EXPERIMENTAL before including it, if you really want to use it."

stack traceback:
    [C]: in function 'error'
    [@programdir\core\base\os.lua:1004]:
    [@programdir\modules\core\tools\cl.lua:741]: in function 'catch'
    [@programdir\core\sandbox\modules\try.lua:123]: in function 'try'
    [@programdir\modules\core\tools\cl.lua:681]:
    [C]: in function 'xpcall'
    [@programdir\core\base\utils.lua:244]:
    [@programdir\core\tool\compiler.lua:288]: in function 'compile'
    [@programdir\modules\private\action\build\object.lua:91]: in function 'script'
    [@programdir\modules\private\action\build\object.lua:122]: in function 'build_object'
    [@programdir\modules\private\action\build\object.lua:147]: in function 'jobfunc'
    [@programdir\modules\async\runjobs.lua:241]:
    [C]: in function 'xpcall'
    [@programdir\core\base\utils.lua:244]: in function 'trycall'
    [@programdir\core\sandbox\modules\try.lua:117]: in function 'try'
    [@programdir\modules\async\runjobs.lua:224]: in function 'cotask'
    [@programdir\core\base\scheduler.lua:406]:

stack traceback:
        [C]: in function 'error'
        @programdir\core\base\os.lua:1004: in function 'base/os.raiselevel'
        (...tail calls...)
        @programdir\core\main.lua:329: in upvalue 'cotask'
        @programdir\core\base\scheduler.lua:406: in function <@programdir\core\base\scheduler.lua:399>

[waruqi]

full build logs, not only error logs

[CheapMeow]

defition_log.txt

[waruqi]

In this case, GLM_ENABLE_EXPERIMENTAL is not defined.

I saw GLFW_INCLUDE_NONE is defined, but I cannot find it in your provided xmake.lua

compiling.EditorDebug src\meow_runtime\function\render\render_resources\uniform_buffer.cpp�[0m
"E:\software\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\bin\HostX64\x64\cl.exe" -c -nologo -Zi -FS -Fdbuild\EditorDebug\meow_runtime.pdb -Od -std:c++20 -IE:\repositories\MeowEngine\src\meow_runtime -DMEOW_EDITOR -DMEOW_DEBUG -DGLFW_INCLUDE_NONE /EHsc -external:W0 -external:IC:\Users\blizz\AppData\Local.xmake\packages\g\glm\1.0.1\788496219b2d40629f92bac6907b6bba\include -external:W0 -external:IC:

[CheapMeow]

That is because I use default config glfw_include=none of glfw deps

add_requires("glfw")

In xmake-repo:

package("glfw")

    ...
    add_configs("glfw_include", {description = "Choose submodules enabled in glfw", default = "none", type = "string", values = {"none", "vulkan", "glu", "glext", "es2", "es3", "system"}})
    ...
    on_load(function (package)
        local glfw_include = package:config("glfw_include")
        if glfw_include ~= "system" then
            package:add("defines", "GLFW_INCLUDE_" .. glfw_include:upper())
        end
    ...

[waruqi]

it works for me on my macos.

-DGLM_ENABLE_EXPERIMENTAL

[ 50%]: cache compiling.release src/main.cpp
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -c -Qunused-argument
s -target x86_64-apple-macos15.1 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/D
eveloper/SDKs/MacOSX15.1.sdk -Isrc -DENGINE_ROOT_DIR=\"/private/tmp/test\" -DNOMINMAX -DGLM_ENABLE_EXPERIMENTAL -
DGLFW_INCLUDE_VULKAN -DGLFW_EXPOSE_NATIVE_WIN32 -DVK_USE_PLATFORM_WIN32_KHR -DVK_NO_PROTOTYPES -DIMGUI_DEFINE_MAT
H_OPERATORS -DGLFW_INCLUDE_NONE -DGL_SILENCE_DEPRECATION -framework Cocoa -framework IOKit -framework OpenGL -isy
stem /Users/ruki/.xmake/packages/g/glm/1.0.1/0f715c4cc6014c1cb44ef7926f0e090a/include -isystem /Users/ruki/.xmake
/packages/g/glfw/3.4/271d9849b1d440aa90104648b74310d7/include -isystem /Users/ruki/.xmake/packages/v/volk/1.3.290
+0/e58152f18b744dbab8dfd54e2d04c425/include -isystem /Users/ruki/.xmake/packages/v/vulkan-headers/1.3.290+0/c7bc6
57a94154a8c877999855162d4c5/include -isystem /Users/ruki/.xmake/packages/s/spirv-cross/1.3.268+0/e6221815ef5a44c8
90219bbdf61134da/include -isystem /Users/ruki/.xmake/packages/s/stb/2024.06.01/c5dad42a0d624f5a9cc4dce48178a35e/i
nclude -isystem /Users/ruki/.xmake/packages/s/stb/2024.06.01/c5dad42a0d624f5a9cc4dce48178a35e/include/stb -isyste
m /Users/ruki/.xmake/packages/a/assimp/v5.4.3/70c2032c2cae4584891588798ee17240/include -isystem /Users/ruki/.xmak
e/packages/m/minizip/v1.2.13/d1916a67b92342b78e85cd63eb5d6d72/include -isystem /Users/ruki/.xmake/packages/m/mini
zip/v1.2.13/d1916a67b92342b78e85cd63eb5d6d72/include/minizip -isystem /Users/ruki/.xmake/packages/z/zlib/v1.3.1/3
323a56e4f3c40c2895f732924aff059/include -o build/.objs/test_app/macosx/x86_64/release/src/main.cpp.o src/main.cpp
[ 75%]: archiving.release libtest_app.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ar -cr build/macosx/x86_64
/release/libtest_app.a build/.objs/test_app/macosx/x86_64/release/src/main.cpp.o
[100%]: build ok, spent 0.221s