Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to httpaux & touchstone (remove gokit metrics) #468

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Sep 9, 2024

  • upgrade to httpaux & touchstone (remove gokit metrics)
  • fix linter

- upgrade to httpaux & touchstone (remove gokit metrics)
- fix linter
@denopink denopink merged commit 4b44b82 into main Sep 9, 2024
18 of 19 checks passed
@denopink denopink deleted the denopink/feat/upgrade-to-touchstone-httpaux branch September 9, 2024 17:39
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 65.04854% with 72 lines in your changes missing coverage. Please review.

Project coverage is 59.15%. Comparing base (4ab578a) to head (f74a2a2).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
control.go 0.00% 28 Missing ⚠️
primaryHandler.go 0.00% 26 Missing ⚠️
main.go 0.00% 16 Missing ⚠️
metrics.go 98.46% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   60.65%   59.15%   -1.50%     
==========================================
  Files          18       18              
  Lines        1431     1496      +65     
==========================================
+ Hits          868      885      +17     
- Misses        522      569      +47     
- Partials       41       42       +1     
Flag Coverage Δ
unittests 59.15% <65.04%> (-1.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant