Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep mob learner doesn't work with spectre anchor / normalizes its nbt #46

Open
hacatu opened this issue Jul 30, 2019 · 0 comments
Open

Comments

@hacatu
Copy link

hacatu commented Jul 30, 2019

The spectre anchor from random things is a really overpowered item that adds an nbt tag to nonstackable items that makes them not lost on death. It can be applied to the deep mob learner, but upon opening the deep mob learner the tag it adds will be removed. I expect this is caused by either writing back only relevant parts of the nbt tag causing injected tags to be dropped, or possibly by actively stripping injected tags.

Based on a cursory look at the code, I think this is caused by the end of ItemDeepLearner.setContainedItems where the deep learner's tag is set to the list of items, rather than setting some field in the tag to the list. Unfortunately if that is the problem, a fixed version of the mod would have to either go through all items in the world and update the nbt of any old style deep mob learners, or (probably better) have the deep mob learner check for the old format when it would normally need to and update it if it is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant