Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A newline should be added at end of included files, if not present #3

Open
tgjones opened this issue May 15, 2015 · 0 comments
Open

Comments

@tgjones
Copy link
Contributor

tgjones commented May 15, 2015

At the moment, CppNet does not add a newline at the end of an included file, if there is not already one present. This creates a problem, because the #line directive when you come back to the original file ends up on the same line as the last line of the include:

// this is the original file
#line 1 "Include.hlsl"
// this is the include file
int a; #line 43 "OriginalFile.hlsl"
// carry on with the original file

According to this SO answer, all preprocessors these days detect this case, and add a newline for you.

I've had a look, but I'm not entirely sure where this should be added in CppNet. Any ideas?

(By the way, @xoofx, have you hit this issue in Paradox?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant