-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React I13n 3.0.0 #224
Comments
Regarding the move to the new context api (#190), I created a sample repo with some of the issues we're facing today: https://github.com/antonychan/react-i13n-context. Hopefully can provide you some use cases to work with! We have some components that consume more than one context. We can get around that issue now by using a higher-order-component like In the repo, I created three components that consume multiple contexts in different ways:
In the renderProps example, moving to the new context API (and exposing the consumer) should allow us to nest multiple consumers (https://reactjs.org/docs/context.html#consuming-multiple-contexts) In the
|
@roderickhsiao whats the status of this? Also what are your thoughts on introducing hooks? |
@redonkulus going to try the context for the next change, hopefully I can made it. I think internally we can use hook, and provide both hooks and HOC externally (for people using class) to access |
Hi @roderickhsiao , is there any task unassigned that I can help with upgrading react-i13n to 3.0.0 ? |
If anyone can help #259 will unblock the biggest task for 3.0.0 :) |
@roderickhsiao my yearly check-in on this migration work. What is left to be done? Looks like #259 was merged a while ago. |
I think only documentation left, the code should be stable enough. |
@redonkulus I'll try removing grunt and modernize the build probably this week or next |
@roderickhsiao awesome. lets make sure the docs are ok too. I think they are based on your context PR. |
then we can get 3.0.0 published and out of alpha. |
3.0.0 has been released, we can close this now. |
Use as a master tracker for 3.0.0 release.
Enhancement:
Good to have enhancement
Breaking Changes
followLink
intersection-observer
polyfill if you are need to support browsers doesnt have the function[3.0.0-alpha.0] #218
[3.0.0-alpha.1] #226
[3.0.0-alpha.2] #228
[3.0.0-alpha.3] #229
[3.0.0-alpha.5] #259
The text was updated successfully, but these errors were encountered: