Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http subs filter header ignored, this may be a compressed response. while reading response header from upstream, client #10

Open
TommehM opened this issue May 9, 2014 · 4 comments

Comments

@TommehM
Copy link

TommehM commented May 9, 2014

2014/05/09 13:28:50 [warn] 19808#0: *312 http subs filter header ignored, this may be a compressed response. while reading response header from upstream, client: xx.xx.xx.xx, server: , request: "GET / HTTP/1.1", upstream: "http://194.71.107.80:80/", host: "tpb.rtbt.me", referrer: "http://tpb.rtbt.me/top/101"

@yaoweibin
Copy link
Owner

Yes. If the response is compressed. The substitution will not work. Is there any problem?

@stucki
Copy link

stucki commented Jan 28, 2016

Yes there is a problem: If the Content-Encoding is set to "none" then the module does still assume that the response is compressed.
I understand that the header is non-standard (https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.11), however it seems to be needed in some special cases. I'm currently testing that, however and for the time being, I think that ignoring "none" wouldn't hurt...
See also getgrav/grav#548

@nagarciah
Copy link

Hi. Thanks a lot for your work, it's very valuable. Since compressed responses are a vast majority, are there plans to enable substitution module to work on compressed responses?.

@guitarama
Copy link

i worked around this one by removing the Accept-Encoding header going to proxy then enabling gzip on the proxied response, e.g.

    gzip_proxied any;
    ...
        proxy_set_header Accept-Encoding '';
        subs_filter ... ...;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants