Base clases provide more protected methods for subclasses #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WorkQueues now has a protected constructor that accepts WebURLTupleBinding as a parameter. It helps to use custom WebURLs with aditional parameters that require a custom WebURLTupleBinding
Now the constructor calls createWorkQueues to get a new WorkQueues instance. This allows subclasses to override this behaviour and create custom work queues.
Now CrawlController subclasses can create custom Frontiers.
Function createEmptyWebURL created to allow subclasses of CrawlController create their custom WebURLs in addSeed operations.
scheduleOutgoingUrls and performRedirect created in order to be able to modify behaviour in subclasses, schedule and scheduleAll wrap frontier functions so subclases can schedule manually.
redirectionPhase separated into a protected method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've prepared a branch with some modifications I had to include in the codebase in order to provide custom WebURLs with adittional fields (and the necesary diferent WebURLTupleBindings).
In order to achieve that, I had to introduce the following modifications: