test (#1)

* Rename battle terrain to environment

* Address concerns

* Fix defines in MAP_NUM and MAP_GROUP

* Change metatile behaviors to enum (pret#2027)

* Revert MB name changes

* Remove accidental expansion leftovers

* Update wild encounters json template

* Move heal locations data to their associated map.json (pret#2034)

* Generate local IDs from map.json files

* Fix typo, remove old size check

* Continue adding local IDs to map.json files

* Finish adding local IDs to map.json files

* OBJ_EVENT_ID_PLAYER/CAMERA -> LOCALID_PLAYER/CAMERA

* Fix event_constants recipe running twice

* Generate MAPSEC constants from JSON

* Use size constants for MAPSEC popup theme array

* Update vars.h (cleanup)

Removed an extra are

* extern const gBasicHitSplatSpriteTemplate

* extern gAncientPowerRockSpriteTemplate fix

* remove undef TASK_NONE from list_menu

* extern void * const gNullScriptPtr;

* Fixed Gen 1/2's Transform "pink color" reference

* Fixed potential unaligned issue in PC screen

* Fix CaveTransition pals

* Define field script opcode constants (pret#2005)

Replace the magic number opcodes in field script command macros with
these new constants

* Document bard music (pret#2053)

* Missing bard song limit constants
* Index bard sound arrays with word constants
* Document bard music

* Extern gSprites and gOamMatrices with known array size (pret#2090)

* Fix conflicting types for rotating gate functions (pret#2087)

* Replace easy_chat alphabetialOrder magic numbers with EC_INDEX values (pret#2096)

* Fixed switchout bug in multibattle where order of mons gets messed up (pret#2099)

* Generate heal location constants automatically, move data back to a single file.

* Converted apprenctice IDs from hex to decimal

* Fix collision comparison in PlayerNotOnBikeMoving

* Fix offset for towerInterview in BattleFrontier

* Remove casts in decoration.c (pret#2110)

* Changed unused compressed pal include from u16 to u32

* Renamed a berry tag variable

* Fix union room typo

* Align gMPlayTrack_BGM

* GENDER_COUNT in sPlayer/RivalAvatarGfxIds (pret#2117)

* make linkDirection more robust to member reordering

* Fixed a compilation error if using AGBPrint as your log handler, misnamed AGBPrintfInit should be AGBPrintInit

* Fixes for Mirage Tower graphics (pret#2120)

* Add documentation for CreateCeilingCrumbleSprites

* Combine mirage tower graphics

* Add comment about mirage tower / player palette

* Added constant in Birch speech dialogue

* BUFFER_A/B -> BATTLELINKMSGTYPE; link send/recv. task data names

Replaced the BUFFER_A and BUFFER_B constants with the BATTLELINKMSGTYPE enum, which also identifies the "controller becoming idle" message type.

Named the task data for the link send task and the link receive task. Added macros to functions related to those tasks, for legibility.

* gBattleControllerExecFlags bits now identified via helper macros

Created "exposition" macros to describe operations performed on gBattleControllerExecFlags. Updated the battle engine internals to use them, to more clearly document how battle link communications actually work.

* gBattleControllerExecFlags macro in MarkAllBattlersForControllerExec

whoops, missed one

* Additional fixes to last few commits

ROM now compiles, but it's not comparing as equal...

* Update battle_controllers.h

Simplified macros.

* Fixed find-and-replace mistake

Functions were using the wrong constant.

* Renamed BATTLELINKMSGTYPE_ to BATTLELINKCOMMTYPE_

I want to avoid the word "message" since PRET has already chosen "battle message" as the term for predefined strings usable in the battle scripts and UI.

I was considering the term "battle link packet" instead, but the library for wireless communications already uses the word "packet" even though GBATEK does not. I'm going with "battle link communication type" instead. For this particular context, I don't think we need a compound noun ("X type"); the singular noun "type" is fine enough.

* Tweaks to documentation comments

* Update battle_controllers.h

typo

* Identified task and sprite fields related to battle weather animations

Named task and sprite fields related to the animations for Hail, Rain Dance, and Sandstorm.

* Battle anims, ice: ARRAY_COUNT works if used with a cast

* Shorter names for engine/controller communication enum members

* Added missing include due to g++ changes

* InitSpritePosToAnimAttacker documentation

* Rename battlerId to battler for consistency (pret#2126)

* Replace: moveId -> move, moveIdx -> moveIndex (pret#2134)

* Add BattlerId enum and document (pret#2135)

* Remove files that should not have been committed

* Warn on suspicious setvar usages

* Streamline pointer notation (pret#2139)

* Fixes for C23 Support (pret#2138)

* fixes for c23 support
* include global.h in m4a.c & remove <string.h> include

* Update header files to match source files (pret#2143)

* Correct C23 Checks (pret#2144)

* Remove berry yield bug fix

* Rename ItemId_GetX to GetItemX (pret#2116)

* Remove files that were wrongly commited

* Remove map_group_count.h

* sync list menu functions with firered

* replace magic numbers with enums

* fix sprite count in RepeatBallOpenParticleAnimation

* Fix AnimItemSteal_Step3 and AnimKnockOffOpponentsItem matches

* Fixed typo in sMoveRelearnerMenuState (pret#2155)

* Add missing uses of LOCALID_NONE for trainerbattle

* Fix wrong keep temps files directory in makefile

* Move gTradePlatform_Tilemap to header (pret#2088)

* Match graphics declarations with externs (pret#2089)

* Fix sGpuRegBuffer potential alignment issues (pret#2157)

* Ensure sMonMarkings_Gfx alignment (pret#2158)

---------

Co-authored-by: Bassoonian <[email protected]>
Co-authored-by: psf <[email protected]>
Co-authored-by: GriffinR <[email protected]>
Co-authored-by: shachar700 <[email protected]>
Co-authored-by: Martin Griffin <[email protected]>
Co-authored-by: DizzyEggg <[email protected]>
Co-authored-by: Eduardo Quezada <[email protected]>
Co-authored-by: Hedara <[email protected]>
Co-authored-by: Raymond Dodge <[email protected]>
Co-authored-by: Frank <[email protected]>
Co-authored-by: Isaac Aronson <[email protected]>
Co-authored-by: cawtds <[email protected]>
Co-authored-by: pokemonmasteraaron <[email protected]>
Co-authored-by: Estellar <[email protected]>
Co-authored-by: DavidJCobb <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Kurausukun <[email protected]>
Co-authored-by: Abaresk <[email protected]>
Co-authored-by: AlexOn1ine <[email protected]>
Co-authored-by: ghoulslash <[email protected]>

Author: 20 people

Makefile

@@ -115,7 +115,7 @@ INCLUDE_SCANINC_ARGS := $(INCLUDE_DIRS:%=-I %)
 O_LEVEL ?= 2
 CPPFLAGS := $(INCLUDE_CPP_ARGS) -Wno-trigraphs -DMODERN=$(MODERN)
 ifeq ($(MODERN),0)
-  CPPFLAGS += -I tools/agbcc/include -I tools/agbcc -nostdinc -undef
+  CPPFLAGS += -I tools/agbcc/include -I tools/agbcc -nostdinc -undef -std=gnu89
   CC1 := tools/agbcc/bin/agbcc$(EXE)
   override CFLAGS += -mthumb-interwork -Wimplicit -Wparentheses -Werror -O$(O_LEVEL) -fhex-asm -g
   LIBPATH := -L ../../tools/agbcc/lib
@@ -283,7 +283,8 @@ generated: $(AUTO_GEN_TARGETS)
 %.rl:     %      ; $(GFX) $< $@
 
 clean-generated:
-	-rm -f $(AUTO_GEN_TARGETS)
+	@rm -f $(AUTO_GEN_TARGETS)
+	@echo "rm -f <AUTO_GEN_TARGETS>"
 
 ifeq ($(MODERN),0)
 $(C_BUILDDIR)/libc.o: CC1 := $(TOOLS_DIR)/agbcc/bin/old_agbcc$(EXE)
@@ -312,10 +313,10 @@ ifneq ($(KEEP_TEMPS),1)
 	@echo "$(CC1) <flags> -o $@ $<"
 	@$(CPP) $(CPPFLAGS) $< | $(PREPROC) -i $< charmap.txt | $(CC1) $(CFLAGS) -o - - | cat - <(echo -e ".text\n\t.align\t2, 0") | $(AS) $(ASFLAGS) -o $@ -
 else
-	@$(CPP) $(CPPFLAGS) $< -o $*.i
-	@$(PREPROC) $*.i charmap.txt | $(CC1) $(CFLAGS) -o $*.s
-	@echo -e ".text\n\t.align\t2, 0\n" >> $*.s
-	$(AS) $(ASFLAGS) -o $@ $*.s
+	@$(CPP) $(CPPFLAGS) $< -o $(C_BUILDDIR)/$*.i
+	@$(PREPROC) $(C_BUILDDIR)/$*.i charmap.txt | $(CC1) $(CFLAGS) -o $(C_BUILDDIR)/$*.s
+	@echo -e ".text\n\t.align\t2, 0\n" >> $(C_BUILDDIR)/$*.s
+	$(AS) $(ASFLAGS) -o $@ $(C_BUILDDIR)/$*.s
 endif
 
 $(C_BUILDDIR)/%.d: $(C_SUBDIR)/%.c

asm/macros/battle_script.inc

@@ -1044,7 +1044,7 @@
 	.byte 0xcb
 	.endm
 
-	.macro callterrainattack
+	.macro callenvironmentattack
 	.byte 0xcc
 	.endm
 
@@ -1192,7 +1192,7 @@
 	.4byte \ptr
 	.endm
 
-	.macro settypetoterrain ptr:req
+	.macro settypetoenvironment ptr:req
 	.byte 0xeb
 	.4byte \ptr
 	.endm