feat: use relative entity path in schema actions #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
reviewed
Sep 27, 2024
| @@ -14,3 +19,19 @@ export function transformPath(path: string, dbName: string): string { | |||
|
|
|||
| return result; | |||
| } | |||
|
|
|||
| export function isDomain(path: string, type?: EPathType) { | |||
There was a problem hiding this comment.
Some tests would be very great
astandrik
reviewed
Sep 27, 2024
| @@ -14,3 +19,19 @@ export function transformPath(path: string, dbName: string): string { | |||
|
|
|||
| return result; | |||
| } | |||
|
|
|||
| export function isDomain(path: string, type?: EPathType) { | |||
There was a problem hiding this comment.
export function isDomain(path: string, type?: EPathType): boolean {
if (type !== EPathType.EPathTypeDir) {
return false;
}
return path.split('/').length === 2 && path.startsWith('/');
}
astandrik
reviewed
Sep 27, 2024
| @@ -14,3 +19,19 @@ export function transformPath(path: string, dbName: string): string { | |||
|
|
|||
| return result; | |||
| } | |||
|
|
|||
| export function isDomain(path: string, type?: EPathType) { | |||
There was a problem hiding this comment.
Not sure if these tests return what expected
Double check them please
import { isDomain } from './path-utils';
import { EPathType } from './types';
describe('isDomain', () => {
it('should return true for valid domain paths', () => {
expect(isDomain('/domain', EPathType.EPathTypeDir)).toBe(true);
expect(isDomain('/another-domain', EPathType.EPathTypeDir)).toBe(true);
});
it('should return false for non-directory paths', () => {
expect(isDomain('/domain', EPathType.EPathTypeFile)).toBe(false);
expect(isDomain('/domain', undefined)).toBe(false);
});
it('should return false for paths without slash', () => {
expect(isDomain('domain', EPathType.EPathTypeDir)).toBe(false);
});
it('should return false for paths with multiple slashes', () => {
expect(isDomain('/domain/subdomain', EPathType.EPathTypeDir)).toBe(false);
expect(isDomain('/domain/', EPathType.EPathTypeDir)).toBe(false);
});
it('should return false for empty paths', () => {
expect(isDomain('', EPathType.EPathTypeDir)).toBe(false);
});
it('should return true for root path', () => {
expect(isDomain('/', EPathType.EPathTypeDir)).toBe(true);
});
});
Raubzeug
force-pushed
the
1329-copy-path
branch
from
64c65e0
to
a1e3720
Compare
artemmufazalov
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: ✅
Current: 79.08 MB | Main: 79.08 MB
Diff: +0.00 MB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information