Skip to content

YQL query dumper - fail dump if DQ uses files #27628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
+23 −0
Merged

YQL query dumper - fail dump if DQ uses files #27628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ydb/library/yql/providers/dq/provider/exec/yql_dq_exectransformer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,12 @@ class TDqExecTransformer: public TExecTransformerBase, TCounters
return filesRes;
}
FlushCounter("FreezeUsedFiles");

auto& qContext = State->TypeCtx->QContext;
if (qContext.CanWrite() && qContext.CaptureMode() == EQPlayerCaptureMode::Full && !files.empty()) {
YQL_CLOG(DEBUG, ProviderDq) << "DQ full capture has not been taken: file dump is unsupported";
State->IsFullCaptureReady = false;
}
// copy-paste }

TScopedAlloc alloc(__LOCATION__, NKikimr::TAlignedPagePoolCounters(), State->FunctionRegistry->SupportsSizedAllocators());
Expand Down Expand Up @@ -1347,6 +1353,12 @@ class TDqExecTransformer: public TExecTransformerBase, TCounters
return filesRes;
}
FlushCounter("FreezeUsedFiles");

auto& qContext = State->TypeCtx->QContext;
if (qContext.CanWrite() && qContext.CaptureMode() == EQPlayerCaptureMode::Full && !files.empty()) {
YQL_CLOG(DEBUG, ProviderDq) << "DQ full capture has not been taken: file dump is unsupported";
State->IsFullCaptureReady = false;
}
// copy-paste }

THashMap<TString, TString> secureParams;
Expand Down Expand Up @@ -1900,6 +1912,12 @@ class TDqExecTransformer: public TExecTransformerBase, TCounters
continue;
}
FlushCounter("FreezeUsedFiles");

auto& qContext = State->TypeCtx->QContext;
if (qContext.CanWrite() && qContext.CaptureMode() == EQPlayerCaptureMode::Full && !files.empty()) {
YQL_CLOG(DEBUG, ProviderDq) << "DQ full capture has not been taken: file dump is unsupported";
State->IsFullCaptureReady = false;
}
// copy-paste }

auto settings = std::make_shared<TDqSettings>(*commonSettings);
Expand Down
4 changes: 4 additions & 0 deletions ydb/library/yql/providers/dq/provider/yql_dq_datasink.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,10 @@ class TDqDataProviderSink: public TDataProviderBase {
}
}

bool IsFullCaptureReady() override {
return State->IsFullCaptureReady;
}

const TDqState::TPtr State;

TLazyInitHolder<IGraphTransformer> LogOptTransformer;
Expand Down
1 change: 1 addition & 0 deletions ydb/library/yql/providers/dq/provider/yql_dq_state.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ struct TDqState: public TThrRefBase {
const TString VanillaJobMd5;
TDqConfiguration::TPtr Settings = MakeIntrusive<TDqConfiguration>();
bool ExternalUser;
bool IsFullCaptureReady = true;

TMutex Mutex;
THashMap<ui32, TOperationStatistics> Statistics;
Expand Down
Loading