Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add as part of test suite a check for handling airdrops of want token on strategy #29

Open
storming0x opened this issue Feb 20, 2021 · 4 comments
Open

Add as part of test suite a check for handling airdrops of want token on strategy #29

storming0x opened this issue Feb 20, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers p2 Important

Comments

@storming0x
Copy link

This is based on an issue we found on strategy logic not handling the case when somebody airdrops want tokens or any token related with balance calculations and can cause issues with withdrawals

should be based on this test:

emilianobonassi/yIdleStrategies@f91cb73
@storming0x storming0x changed the title Add as part of test suite a check for airdrop on strategy Add as part of test suite a check for handling airdrops of want token on strategy Feb 20, 2021
@storming0x storming0x added enhancement New feature or request good first issue Good for newcomers p2 Important labels Feb 20, 2021
@fubuloubu
Copy link
Member

Excellent candidate for a fuzz test

@jmonteer
Copy link

@storming0x including this in #53

@jmonteer jmonteer mentioned this issue Jun 28, 2021
Closed
8 tasks
@milkyklim
Copy link

@jmonteer @storming0x was this one ever integrated?

@pandadefi
Copy link
Contributor

We have an opened pr that needs to be refreshed #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers p2 Important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fubuloubu @storming0x @milkyklim @jmonteer @pandadefi