Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total Holdings is summing Vault and Strategy Holdings #175

Open
dudesahn opened this issue Oct 29, 2020 · 2 comments
Open

Total Holdings is summing Vault and Strategy Holdings #175

dudesahn opened this issue Oct 29, 2020 · 2 comments

Comments

@dudesahn
Copy link

On the yearn.finance/stats page, Total Holdings is summing Vault and Strategy Holdings, which is a misleading number (and not a useful metric), as Vault Holdings already includes everything in the Strategy.

Screen Shot 2020-10-28 at 3 38 29 PM

For now, I would advocate for simply removing the "Total Holdings" box and only having three (centered) boxes at the top of the stats page.

@WrongNebula
Copy link

As an end user, Total holdings should be the TVL, it should be the most accurate TVL (compared to stats.finance and DeFi pulse or debanking)

@dudesahn
Copy link
Author

@WrongNebula I agree totally. I would argue for including the v2/v3 yEarn contracts as well in "Total Holdings".

However, TVL in this case (if we're just looking at yVaults, which seems to be what this page is focused on) is the same thing as "Total Vault Holdings". If we add in the holdings in all of the yEarn contracts, then I think that would be a good "Total Holdings".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@dudesahn @WrongNebula and others