Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map GROUP value not saving on map switch #20

Open
ghost opened this issue Dec 4, 2017 · 4 comments
Open

Map GROUP value not saving on map switch #20

ghost opened this issue Dec 4, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented Dec 4, 2017

Short video re-creating the issue: https://i.imgur.com/d8AOX8R.gifv

When the map GROUP value is changed (in this situation, to alter the roof tile appearance in a town) from within Map Properties, you click 'save' but it reverts to the old GROUP value upon returning to the map. A different value such as MUSIC does save on exit and does not revert when returning to the map.

@yenatch
Copy link
Owner

yenatch commented Dec 4, 2017

yeah. i should probably grey it out so you can't edit it, since it doesn't save this way. changing the group would also mean some reordering the same way adding a map does it, which it doesn't do yet

@SachaSCG
Copy link

SachaSCG commented Dec 4, 2017

But changing the group also makes the design of the roofs change, how can this be done alternatively then?

@ghost
Copy link
Author

ghost commented Dec 4, 2017

But changing the group also makes the design of the roofs change, how can this be done alternatively then?

That's a good point - goldenrod and azelea town share the same tileset, but the roof graphics are completely different. I wonder how it is coded to do that, do you know yenatch?

@yenatch
Copy link
Owner

yenatch commented Dec 4, 2017

you can change the group for real by moving the map into the right group in constants/map_constants.asm and maps/map_headers.asm. i think it's just those two files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants