Skip to content
This repository has been archived by the owner on Jul 19, 2020. It is now read-only.

I think it's batch_callback, not send_message_batch. #113

Open
hituzi-no-sippo opened this issue Jul 2, 2020 · 1 comment
Open

I think it's batch_callback, not send_message_batch. #113

hituzi-no-sippo opened this issue Jul 2, 2020 · 1 comment

Comments

@hituzi-no-sippo
Copy link
Contributor

The reason is that it writes "a Callback<IN> is returned".

### send\_message\_batch
Registers a callback that sends a batch of many messages at once when it is executed. If any of the
messages cause the component to re-render, the component will re-render after all messages in the
batch have been processed. A `Fn(IN) -> COMP::Message` is provided and a `Callback<IN>` is returned.

send_message_batch does not return Callback<IN> , but batch_callback return Callback<IN>.

If it's correct, I create a pull request.

@jstarry
Copy link
Member

jstarry commented Jul 5, 2020

@hituzi-no-sippo yes, good catch. It should be batch_callback 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants