Skip to content

Commit 551f96d

Browse files
committed
Remove REMOTE_PORT dependency from UnixSocketTest.PeerPid
1 parent eacc1ca commit 551f96d

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ example/one_time_request
2323
!example/one_time_request.*
2424
example/server_and_client
2525
!example/server_and_client.*
26+
example/accept_header
27+
!example/accept_header.*
2628
example/*.pem
2729
test/httplib.cc
2830
test/httplib.h

test/test.cc

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ TEST_F(UnixSocketTest, PeerPid) {
196196
std::string remote_port_val;
197197
svr.Get(pattern_, [&](const httplib::Request &req, httplib::Response &res) {
198198
res.set_content(content_, "text/plain");
199-
remote_port_val = req.get_header_value("REMOTE_PORT");
199+
remote_port_val = std::to_string(req.remote_port);
200200
});
201201

202202
std::thread t{[&] {
@@ -11236,7 +11236,8 @@ TEST(ForwardedHeadersTest, NoProxiesSetting) {
1123611236
EXPECT_EQ(StatusCode::OK_200, res->status);
1123711237

1123811238
EXPECT_EQ(observed_xff, "203.0.113.66");
11239-
EXPECT_TRUE(observed_remote_addr == "::1" || observed_remote_addr == "127.0.0.1");
11239+
EXPECT_TRUE(observed_remote_addr == "::1" ||
11240+
observed_remote_addr == "127.0.0.1");
1124011241
}
1124111242

1124211243
TEST(ForwardedHeadersTest, NoForwardedHeaders) {
@@ -11269,7 +11270,8 @@ TEST(ForwardedHeadersTest, NoForwardedHeaders) {
1126911270
EXPECT_EQ(StatusCode::OK_200, res->status);
1127011271

1127111272
EXPECT_EQ(observed_xff, "");
11272-
EXPECT_TRUE(observed_remote_addr == "::1" || observed_remote_addr == "127.0.0.1");
11273+
EXPECT_TRUE(observed_remote_addr == "::1" ||
11274+
observed_remote_addr == "127.0.0.1");
1127311275
}
1127411276

1127511277
TEST(ForwardedHeadersTest, SingleTrustedProxy_UsesIPBeforeTrusted) {
@@ -11296,7 +11298,8 @@ TEST(ForwardedHeadersTest, SingleTrustedProxy_UsesIPBeforeTrusted) {
1129611298
svr.wait_until_ready();
1129711299

1129811300
Client cli(HOST, PORT);
11299-
auto res = cli.Get("/ip", {{"X-Forwarded-For", "198.51.100.23, 203.0.113.66"}});
11301+
auto res =
11302+
cli.Get("/ip", {{"X-Forwarded-For", "198.51.100.23, 203.0.113.66"}});
1130011303

1130111304
ASSERT_TRUE(res);
1130211305
EXPECT_EQ(StatusCode::OK_200, res->status);
@@ -11330,8 +11333,7 @@ TEST(ForwardedHeadersTest, MultipleTrustedProxies_UsesClientIP) {
1133011333

1133111334
Client cli(HOST, PORT);
1133211335
auto res = cli.Get(
11333-
"/ip",
11334-
{{"X-Forwarded-For", "198.51.100.23, 203.0.113.66, 192.0.2.45"}});
11336+
"/ip", {{"X-Forwarded-For", "198.51.100.23, 203.0.113.66, 192.0.2.45"}});
1133511337

1133611338
ASSERT_TRUE(res);
1133711339
EXPECT_EQ(StatusCode::OK_200, res->status);
@@ -11364,8 +11366,8 @@ TEST(ForwardedHeadersTest, TrustedProxyNotInHeader_UsesFirstFromXFF) {
1136411366
svr.wait_until_ready();
1136511367

1136611368
Client cli(HOST, PORT);
11367-
auto res = cli.Get("/ip",
11368-
{{"X-Forwarded-For", "198.51.100.23, 198.51.100.24"}});
11369+
auto res =
11370+
cli.Get("/ip", {{"X-Forwarded-For", "198.51.100.23, 198.51.100.24"}});
1136911371

1137011372
ASSERT_TRUE(res);
1137111373
EXPECT_EQ(StatusCode::OK_200, res->status);
@@ -11399,8 +11401,7 @@ TEST(ForwardedHeadersTest, LastHopTrusted_SelectsImmediateLeftIP) {
1139911401

1140011402
Client cli(HOST, PORT);
1140111403
auto res = cli.Get(
11402-
"/ip",
11403-
{{"X-Forwarded-For", "198.51.100.23, 203.0.113.66, 192.0.2.45"}});
11404+
"/ip", {{"X-Forwarded-For", "198.51.100.23, 203.0.113.66, 192.0.2.45"}});
1140411405

1140511406
ASSERT_TRUE(res);
1140611407
EXPECT_EQ(StatusCode::OK_200, res->status);
@@ -11433,9 +11434,8 @@ TEST(ForwardedHeadersTest, HandlesWhitespaceAroundIPs) {
1143311434
svr.wait_until_ready();
1143411435

1143511436
Client cli(HOST, PORT);
11436-
auto res = cli.Get(
11437-
"/ip",
11438-
{{"X-Forwarded-For", " 198.51.100.23 , 203.0.113.66 , 192.0.2.45 "}});
11437+
auto res = cli.Get("/ip", {{"X-Forwarded-For",
11438+
" 198.51.100.23 , 203.0.113.66 , 192.0.2.45 "}});
1143911439

1144011440
ASSERT_TRUE(res);
1144111441
EXPECT_EQ(StatusCode::OK_200, res->status);

0 commit comments

Comments
 (0)