Use only one goal in Makefile (#402)

Author: vjik

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## 1.0.1 under development
 
+- Bug #402: Always use only one goal in Makefile (@vjik)
 - Bug #403: Add DI container delegates configuration (@vjik)
 - Enh #399: Improve message for missing or invalid APP_ENV (@samdark)
 

Makefile

@@ -3,6 +3,8 @@
 CLI_ARGS := $(wordlist 2,$(words $(MAKECMDGOALS)),$(MAKECMDGOALS))
 $(eval $(CLI_ARGS):;@:)
 
+PRIMARY_GOAL := $(firstword $(MAKECMDGOALS))
+
 include docker/.env
 
 # Current user ID and group ID except MacOS where it conflicts with Docker abilities
@@ -22,70 +24,106 @@ DOCKER_COMPOSE_TEST := docker compose -f docker/compose.yml -f docker/test/compo
 # Development
 #
 
+ifeq ($(PRIMARY_GOAL),build)
 build: ## Build docker images
 	$(DOCKER_COMPOSE_DEV) build $(CLI_ARGS)
+endif
 
+ifeq ($(PRIMARY_GOAL),up)
 up: ## Up the dev environment
 	$(DOCKER_COMPOSE_DEV) up -d --remove-orphans
+endif
 
+ifeq ($(PRIMARY_GOAL),down)
 down: ## Down the dev environment
 	$(DOCKER_COMPOSE_DEV) down --remove-orphans
+endif
 
+ifeq ($(PRIMARY_GOAL),clear)
 clear: ## Remove development docker containers and volumes
 	$(DOCKER_COMPOSE_DEV) down --volumes --remove-orphans
+endif
 
+ifeq ($(PRIMARY_GOAL),shell)
 shell: ## Get into container shell
 	$(DOCKER_COMPOSE_DEV) exec app /bin/bash
+endif
 
+ifeq ($(PRIMARY_GOAL),yii)
 yii: ## Execute Yii command
 	$(DOCKER_COMPOSE_DEV) run --rm app ./yii $(CLI_ARGS)
 .PHONY: yii
+endif
 
+ifeq ($(PRIMARY_GOAL),composer)
 composer: ## Run Composer
 	$(DOCKER_COMPOSE_DEV) run --rm app composer $(CLI_ARGS)
+endif
 
+ifeq ($(PRIMARY_GOAL),rector)
 rector: ## Run Rector
 	$(DOCKER_COMPOSE_DEV) run --rm app ./vendor/bin/rector $(CLI_ARGS)
+endif
 
+ifeq ($(PRIMARY_GOAL),cs-fix)
 cs-fix: ## Run PHP CS Fixer
 	$(DOCKER_COMPOSE_DEV) run --rm app ./vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.php --diff
+endif
 
 #
 # Tests and analysis
 #
 
+ifeq ($(PRIMARY_GOAL),test)
 test:
 	$(DOCKER_COMPOSE_TEST) run --rm app ./vendor/bin/codecept run $(CLI_ARGS)
+endif
 
+ifeq ($(PRIMARY_GOAL),test-coverage)
 test-coverage:
 	$(DOCKER_COMPOSE_TEST) run --rm app ./vendor/bin/codecept run --coverage --coverage-html --disable-coverage-php
+endif
 
+ifeq ($(PRIMARY_GOAL),codecept)
 codecept: ## Run Codeception
 	$(DOCKER_COMPOSE_TEST) run --rm app ./vendor/bin/codecept $(CLI_ARGS)
+endif
 
+ifeq ($(PRIMARY_GOAL),psalm)
 psalm: ## Run Psalm
 	$(DOCKER_COMPOSE_DEV) run --rm app ./vendor/bin/psalm $(CLI_ARGS)
+endif
 
+ifeq ($(PRIMARY_GOAL),composer-dependency-analyser)
 composer-dependency-analyser: ## Run Composer Dependency Analyser
 	$(DOCKER_COMPOSE_DEV) run --rm app ./vendor/bin/composer-dependency-analyser --config=composer-dependency-analyser.php $(CLI_ARGS)
+endif
 
 #
 # Production
 #
 
+ifeq ($(PRIMARY_GOAL),prod-build)
 prod-build: ## PROD | Build an image
 	docker build --file docker/Dockerfile --target prod --pull -t ${IMAGE}:${IMAGE_TAG} .
+endif
 
+ifeq ($(PRIMARY_GOAL),prod-push)
 prod-push: ## PROD | Push image to repository
 	docker push ${IMAGE}:${IMAGE_TAG}
+endif
 
+ifeq ($(PRIMARY_GOAL),prod-deploy)
 prod-deploy: ## PROD | Deploy to production
 	docker -H ${PROD_SSH} stack deploy --with-registry-auth -d -c docker/compose.yml -c docker/prod/compose.yml ${STACK_NAME}
+endif
 
 #
 # Other
 #
 
+ifeq ($(PRIMARY_GOAL),help)
 # Output the help for each task, see https://marmelab.com/blog/2016/02/29/auto-documented-makefile.html
 help: ## This help.
 	@awk 'BEGIN {FS = ":.*?## "} /^[a-zA-Z_-]+:.*?## / {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}' $(MAKEFILE_LIST)
+endif