Skip to content

Commit ae41b87

Browse files
committed
improve
1 parent c1fb121 commit ae41b87

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/DQLQueryBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public function build(QueryInterface $query, array $params = []): array
7878
$sql = "$sql$this->separator$union";
7979
}
8080

81-
$with = $this->buildWith($query->getWith(), $params);
81+
$with = $this->buildWithQueries($query->getWithQueries(), $params);
8282

8383
if ($with !== '') {
8484
$sql = "$with$this->separator$sql";

tests/QueryBuilderTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
use Yiisoft\Db\Expression\Value\Param;
1717
use Yiisoft\Db\Query\Query;
1818
use Yiisoft\Db\Query\QueryInterface;
19+
use Yiisoft\Db\Query\WithQuery;
1920
use Yiisoft\Db\QueryBuilder\Condition\JsonOverlaps;
2021
use Yiisoft\Db\Schema\Column\ColumnInterface;
2122
use Yiisoft\Db\Sqlite\Tests\Provider\QueryBuilderProvider;
@@ -248,8 +249,10 @@ public function testBuildWithQuery(): void
248249
$with2Query = (new Query($db))->select('id')->from('t2')->innerJoin('a1', 't2.id = a1.id')->where('expr = 2');
249250
$with3Query = (new Query($db))->select('id')->from('t3')->where('expr = 3');
250251
$query = (new Query($db))
251-
->addWith($with1Query, 'a1')
252-
->addWith($with2Query->union($with3Query), 'a2')
252+
->withQueries(
253+
new WithQuery($with1Query, 'a1'),
254+
new WithQuery($with2Query->union($with3Query), 'a2'),
255+
)
253256
->from('a2');
254257

255258
[$sql, $queryParams] = $qb->build($query);

0 commit comments

Comments
 (0)