Skip to content

Remove "Condition" suffix from condition classes #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 29, 2025
Merged

Remove "Condition" suffix from condition classes #1006

merged 8 commits into from
Jul 29, 2025

Conversation

@vjik
Copy link
Member

@vjik vjik commented Jul 23, 2025 •
edited
Loading

@vjik vjik mentioned this pull request Jul 23, 2025
Merged
@codecov
Copy link

codecov bot commented Jul 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.94%. Comparing base (333f44d) to head (69a849f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1006      +/-   ##
============================================
+ Coverage     98.84%   98.94%   +0.09%     
  Complexity     1599     1599              
============================================
  Files            97       97              
  Lines          4071     4070       -1     
============================================
+ Hits           4024     4027       +3     
+ Misses           47       43       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Jul 23, 2025
Merged
Merged
Merged
Merged
Merged
@vjik vjik requested a review from a team July 23, 2025 07:30
@vjik vjik added the status:code review The pull request needs review. label Jul 23, 2025
Tigrov
Tigrov approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@Tigrov Tigrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names Hash and Simple look confusing.

@vjik
Copy link
Member Author

vjik commented Jul 23, 2025

The names Hash and Simple look confusing.

Any ideas for rename?

@Tigrov
Copy link
Member

Tigrov commented Jul 23, 2025

Any ideas for rename?

Hash - ColumnMatch
Simple - Condition or leave SimpleCondition

samdark
samdark approved these changes Jul 23, 2025
View reviewed changes
Tigrov
Tigrov reviewed Jul 24, 2025
View reviewed changes
@vjik vjik merged commit 73f0052 into master Jul 29, 2025
71 of 76 checks passed
@vjik vjik deleted the rm-condition-suffix branch July 29, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tigrov Tigrov Tigrov approved these changes

@samdark samdark samdark approved these changes

Assignees

No one assigned

Labels

status:code review The pull request needs review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vjik @Tigrov @samdark