Literal::TypeError tweaks and fix for type check in Enum#345
Open
stevegeek wants to merge 4 commits into
Open
Conversation
joeldrapper
approved these changes
Dec 5, 2025
joeldrapper
reviewed
Dec 5, 2025
Comment on lines
+32
to
+34
| test "can be pattern matched" do | ||
| Age.new(17) | ||
| rescue Literal::TypeError => error |
Collaborator
There was a problem hiding this comment.
Another way you could do this is
error = assert_raises(Literal::TypeError) do
Age.new(17)
endAnd then you can continue to make assertions about the error variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeError#deconstruct_keysprob should return all keys when passednillikeHashsayIt is probably not useful to implicitly convert
Contextto hash so can remove extrato_hashalias (unless we think we might need it)Enum__after_defined__still using oldTypeErrorclass method so update it to useLiteral.check