-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong retimed detection on image sequence clip. #897
base: develop
Are you sure you want to change the base?
Fix wrong retimed detection on image sequence clip. #897
Conversation
For the testing data, we also need to check the retime effects (LinearTimeWarp, FreezeFrame, TimeEffect). Since the method name relates to retiming, this will cover the full range of functions. Great job on practically developing the unittest we really need! I'm thinking about whether we should add the test to the appropriate folder. @kalisp and @antirotor could lend a hand here, especially since |
Before the introduction of Resolve's native OTIO, we mainly relied on two attributes:
With Resolve's interpretation of OTIO now in play, we consider:
We reference the media source to an absolute value with included metadata because of FFMPEG. Since we use FFMPEG for video trimming, it's crucial to have the timecode correctly defined. First, figure out if the clip source range is relative or absolute to the media range. Next, find the relative source frame value and continue as before, making sure to clear up any confusing code that's mistakenly referring to me (old me 😄). |
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
but it can - I added one for my own tests, see feature/OP-1188_better-representation-model branch. |
tests/client/ayon_core/pipeline/editorial/test_media_range_with_retimes.py
Outdated
Show resolved
Hide resolved
The method I originally used this method to calculate how much material needs to be prepared for on-the-fly Flame transcoding. While looking into flame_export.py, which handles ocio clip data, I noticed that from line 256, the available frame range on When I wrote the Flame integration two years ago, I faced the challenge of using the embedded TC on the image sequence. From the code in |
tests/client/ayon_core/pipeline/editorial/test_media_range_with_retimes.py
Outdated
Show resolved
Hide resolved
I was doing some tests within Hiero editorial and noticed some differences in the resulting calculations. Here is the outcome before and after the fix. Since it's an old publisher, I could only copy and paste some resulting logs. |
Co-authored-by: Jakub Trllo <[email protected]>
Thanks for the additional tests in Hiero, I've investigated that a bit more. When I use Hiero native OTIO exporter, our clips are retimed as expected. |
Task linked: OP-8066 Resolve: update to new publisher |
Co-authored-by: Jakub Trllo <[email protected]>
I'm not sure what is state of this PR? |
I'm waiting on approval on this one. |
- Added client path to sys.path in conftest.py - Implemented function to run the repository from code in manage.ps1
@@ -157,6 +157,7 @@ default_help() { | |||
echo -e " ${BWhite}ruff-check${RST} ${BCyan}Run Ruff check for the repository${RST}" | |||
echo -e " ${BWhite}ruff-fix${RST} ${BCyan}Run Ruff fix for the repository${RST}" | |||
echo -e " ${BWhite}codespell${RST} ${BCyan}Run codespell check for the repository${RST}" | |||
echo -e " ${BWhite}run${RST} ${BCyan}Run the repository${RST}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
What "Run the repository" means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested via pytests and also via Resolve and works perfect!
shift; # will remove first arg ("run") from the "$@" | ||
"$POETRY_HOME/bin/poetry" run "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, we're replacing run
with run
?
Changelog Description
This PR addresses the bug described on #895 regarding retiming OTIO clip from image sequence.
Testing notes:
Environment prep
ayon-core\client\pyproject.toml
into root level pyproject.toml under tool.poetry.dev-dependenciesayon-core\poetry.lock
.\tools\manage.ps1 create-env
(windows)Testing
run
.\tools\manage.ps1 run pytest .\tests\client\ayon_core\pipeline\editorial\
(windows)AY-979