Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-3875_Ayon: integrate Hero for review #902

Open
ynbot opened this issue Sep 19, 2024 · 0 comments
Open

AY-3875_Ayon: integrate Hero for review #902

ynbot opened this issue Sep 19, 2024 · 0 comments
Assignees
Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working

Comments

@ynbot
Copy link
Contributor

ynbot commented Sep 19, 2024

Please describe the issue you have acountered?

: Getting this now
m_u_r_p_h_y: seems like a custom code.?<@517365933170491392> can have a look?
illicit05: What are you publishing?
: I haven't really tweaked that script except for adding some debug statements.
: I am publishing a render and a review. The review has a hero version
: the review's hero has a custom anatomy.
illicit05: is it a sequence?
: Yes
illicit05: does the hero template have {@frame} in it?
: oh yes it does
: I'll try removing that and see?
illicit05: no..
illicit05: it looked like it was missing
: oh so was a bug. I see
illicit05: No, I though the hero template did not have {@frame} which could cause the issue.
: ohhh
: lol sorry. miscommunication. But tbf the mp4 shouldn't need the frames in the name. So I should try removing it.
illicit05: No.
illicit05: For some reason integrate hero version thinks it is a sequence.
illicit05: Ok, after some discussion, we think we know what the issue is. Could you send us full output so we can confirm it?
: full error output?
illicit05: Full deadline output.
illicit05: If we're right, then we might hit limitations of current hero version integration logic.
: Here you go 🙂
illicit05: Ok, so maybe we would need to add some debug logs to the plugin, could you do that for us? Looks like you've already tried.
: sure. Will just litter some debug logs around and get a report out for you tomorrow. 🙂
: are there any specific information you would need?
illicit05: at about line 315 has

published_files = repre_info["published_files"]

we need to know the content of published_files variable
illicit05: Ok, that didn't help and I'm confused even more. May I ask about one more log?
there is at about line 362

                _template_filled = path_template_obj.format_strict(
                    anatomy_data
                )

Could you log out what _template_filled contains?
: Hey <@517365933170491392> , the printing helps and I think I understand the problem now and not sure if it was intended or a bug. So I'll try to explain
: Initially we have the project only create heroes for reviews. Not render.

: When we submit the job from 3ds max, we submit it as a render family. Which doesn't have a hero based on the project settings > core bundle. However, because the publish job would take the frames and create a review after, for some reason it was also creating a hero for the render frames

: Which can be seen over here after you told me to print out the _template_filled. I was shocked it was creating the template for the exr (render) even though we only wanted the hero for the .mp4 (review) in this example scenario

: So after I added render to the integrate hero project settings > core bundle, it works

: But yes. The hero and the mp4 would be in the render publish folder.

m_u_r_p_h_y: thank you <@411041885889495040> to dive deep into the hero logic. I will create a ticket to cover the case where only review is configured for creating hero version.
m_u_r_p_h_y: Ayon: integrate Hero for review

How to replicate the issue?

No response

Additional context:

link to discussion on Discord
(might be a private channel)

This issue was automatically created from Clickup ticket AY-3875

@ynbot ynbot added sponsored This is directly sponsored by a client or community member type: bug Something isn't working labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants