Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-6499_Create links to publishing instances instead of attaching review to them #915

Open
ynbot opened this issue Sep 24, 2024 · 3 comments
Assignees
Labels
sponsored This is directly sponsored by a client or community member

Comments

@ynbot
Copy link
Contributor

ynbot commented Sep 24, 2024

Please describe the enhancement you have in mind and explain what the current shortcomings are?

Currently, you can either publish review instance, or attach review to already existing instance. In workflows, where there is just one review to approve all published assets, this is not enough. Good example is multishot workflow, where from one scene you publish to multiple context.

So the user story:
Artist are working on multi-shot workflow - they have one Maya scene with multiple products loaded and they are publishing from it to multiple shots.

In review process, shot is approved when review is published - one review for bunch of product types - like multiple character animation, layout tweaks, etc. So current solution, where you do review for every individual product separately is not an option. Imagine mutlishot maya scene for 10 shots. There is one Layout common for them, but every shot has it's own camera and characters with their own animation.
With current review system you can either create review product that will be published within AYON folder context (like shot) or you can attach review to other product types - like having animation product with review component. So approval is going through latest published versions of product that are ready for review and it doesn't really tell you anything about the status of the shot itself.
Proposal is to have another "review mode" - create review product, but be able to link it with other product types. So you'll create review and you know that this is review for these versions of character animations, this version of camera and this version of layout. And when/if they get approved, the whole shot at that pipeline step (task) is approved. In case of Maya, it could be achieved in similar way we are already using - having review maya set where you can nest other publishing instance to create that relationship - that integrate AYON links to database so you can then write automation like - when this review is approved, approve all linked products.

How would you imagine the implementation of the enhancemenent?

No response

Describe alternatives you've considered:

No response

Additional context:

()
(might be a private channel)

This issue was automatically created from Clickup ticket AY-6499

@ynbot ynbot added sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition labels Sep 24, 2024
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Oct 24, 2024

I don't know how we could achieve the requested result. We have a reviewable per instance (version) -> issue in publishing logic.

Not sure if is possible to assign the same reviewable to multiple versions? How we would change status of it to propagate it to related versions? As far as I know status of reviewable is in fact status of version... -> issue on frontend (backend).

@BigRoy
Copy link
Collaborator

BigRoy commented Oct 24, 2024

The way I understand this is more about 'attaching' what is a review publish from e.g. Maya or Houdini to multiple products - so that e.g. a few animation caches share the same video file as "reviewable". And then when updating the status of that review for example, that then it'd automatically update the status for each product the reviewable was 'linked to'

So you could have a reviewAnimation product (that may have multiple reviewable media) that represents the 'preview' for the shots animation. Then when approving that review - it could automatically approve all publishes of caches of that scene that was published e.g. together or 'linked' to that review.

I feel at the origin, it's less about "reviewables" on the backend/frontend at heart - but maybe I'm thinking about this wrong.

@iLLiCiTiT
Copy link
Member

Then when approving that review - it could automatically approve all publishes of caches of that scene that was published e.g. together or 'linked' to that review.

I know, but if you approve reviewable on frontend, you're changing status of version where it belongs, that's why it would require change of FE and BE. When you change status on reviewable, you change status of version, NOT "reviewable".

@mkolar mkolar removed the type: enhancement Improvement of existing functionality or minor addition label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member
Projects
None yet
Development

No branches or pull requests

4 participants