Deadline: Avoid submitting along OPENPYPE_LOG_NO_COLORS

[BigRoy]

Describe the issue

Currently Deadline submissions pass along OPENPYPE_LOG_NO_COLORS per host per job as EnvironmentKeyValue in the Job's info. However Deadline Job log viewer doesn't support custom coloring so all jobs running through Deadline should run with OPENPYPE_LOG_NO_COLORS=1

Proposal

I propose to remove submitting along OPENPYPE_LOG_NO_COLORS per job but instead set OPENPYPE_LOG_NO_COLORS=1 in the GlobalJobPreLoad.py of the Deadline module whenever it has detected that it's running a OpenPype job.

This would reduce the data send per jobs + reduce the logic required per submission.

Additional Info

Brought up on OpenPype Discord here

[cuID:OP-3897]

[BigRoy]

This still seems relevant to ayon-deadline yet the variable is called AYON_LOG_NO_COLORS.

[BigRoy]

I propose to remove submitting along OPENPYPE_LOG_NO_COLORS per job but instead set OPENPYPE_LOG_NO_COLORS=1 in the GlobalJobPreLoad.py of the Deadline module whenever it has detected that it's running a OpenPype job.

This would reduce the data send per jobs + reduce the logic required per submission.

@iLLiCiTiT @antirotor what do you think of the proposal?

[iLLiCiTiT]

I would say this should be defined by ayon-core, and not deadline. But until this is implemented, it should be set in deadline.

[BigRoy]

But - isn't basically anything running in Deadline AYON_LOG_NO_COLORS=1 - so instead of passing it from anywhere to the job, we could just handle this in globaljobpreload to always set it?

[iLLiCiTiT]

And should deadline know about AYON_LOG_NO_COLORS? It is environment related to ayon-core, if ayon-core changes the terminal colors logic, then deadline is behind.

[BigRoy]

I see - so, we need some logic in core that is capable of disabling this automatically when needed?

[iLLiCiTiT]

Maybe we should allow colored output only in AYON launcher process and don't use colors when headless mode is enabled?

[BigRoy]

I mean - a headless mode is exactly the type of mode that could benefit from colorization if the console supports it. So not sure if that's the best way to do that. Unless there are just very few consoles that actually support that. :')