Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shim cannot be updated if shim is used as main executable #151

Open
iLLiCiTiT opened this issue Aug 16, 2024 · 0 comments
Open

Shim cannot be updated if shim is used as main executable #151

iLLiCiTiT opened this issue Aug 16, 2024 · 0 comments
Labels
type: bug Something isn't working

Comments

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Aug 16, 2024

Current Behavior:

It is not really issue at this exact moment. If future version of ayon-launcher should update shim, it can fail because the shim is actually in use.

What might happen:

  1. Launch shim.
  2. Shim launches AYON launcher.
  3. AYON launcher finds out it has to update to newer version of AYON launcher.
  4. Downloads and installs AYON launcher.
  5. Starts new version of AYON launcher.
  6. New AYON launcher has newer version of shim.
  7. It tries to install it, but fails because shim from 1.) is still running.

Expected Behavior:

We might need to find a better way how to handle shim updates?

Only way I can think of is to install shim under versioned folders and the main executable would be writte n in c. So it is really minimalistic, can find latest shim to use and launch it -> shim for a shim?

/shim
    /ayon - executable written in c (on macOs it would not live here but in `/Applications/AYON.app`)
    /versions - folder where the current shim content is, under coresponding version folder
        /1.0.0
            /ayon - shim 1.0.0
        /1.0.1
            /ayon - shim 1.0.1

Alternative solution

We might find out if it's in use by "moving" existing shim folder. If it fails, then copy installer file to desktop/downloads and show/print message to close all AYON instances and install it manually.

@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant