Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-7020_Autoupdater is not ready for specific dependency and addons paths #153

Open
iLLiCiTiT opened this issue Aug 20, 2024 · 1 comment
Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition

Comments

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Aug 20, 2024

Issue

Distribution has few issues. The most important at this moment might be that it downloads addons, dependency packages and launcher if it does not find it, but at the same time does not validate if other process does it too, so there might be clashes. Thath can happen when 2 processes of ayon are started and both should update, or when 2 different machines are pointing to the same location.

Possible solution

Low hanging fruit fix would be that installation (download and extraction) happens to different folder and only the last step would move it to final location only if is not there yet.

Proper solution would be to create "distribution file" (similar to lock file) before we start download and distribution. The lock file should be looked for before download and update. Other process wanting to download the same thing should wait, they have to find out if they should wait (for cases the distribution fails in other process) so the distribution file should be also updated with progress, in case progress was not updated for some time, the other process can force download and create new distribution file.

The proper solution is more complex and requires major modifications in current distribution logic.

@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Aug 20, 2024
@m-u-r-p-h-y m-u-r-p-h-y added the sponsored This is directly sponsored by a client or community member label Oct 23, 2024
@m-u-r-p-h-y m-u-r-p-h-y changed the title Distribution: Safe update AY-7020_Autoupdater is not ready for specific dependency and addons paths Oct 23, 2024
@m-u-r-p-h-y
Copy link
Member

This issue was manually created from Clickup ticket AY-7020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

2 participants