Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace filter(Boolean) #402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nicod-pc
Copy link

@nicod-pc nicod-pc commented Aug 7, 2024

It seems that filter(Boolean) is quite slow. filter(e => e) is much faster, also faster than lodash. https://www.measurethat.net/Benchmarks/Show/15778/0/compact-vs-filterboolean-vs-filterelement-element

It seems that `filter(Boolean)` is quite slow. `filter(e => e)` is much faster, also faster than lodash.
https://www.measurethat.net/Benchmarks/Show/15778/0/compact-vs-filterboolean-vs-filterelement-element
@loucyx
Copy link

loucyx commented Sep 27, 2024

Are we sure? At the end of the day, an identity function used as a predicate will be internally casted to boolean by Array#filter if the type isn't boolean, and in theory doing the conversion ourselves should be either quicker or the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants