Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attrs dependency #420

Open
philfry opened this issue Aug 13, 2024 · 4 comments
Open

Remove attrs dependency #420

philfry opened this issue Aug 13, 2024 · 4 comments

Comments

@philfry
Copy link

philfry commented Aug 13, 2024

Hi,

since attr is no longer used since v2.5.0, would you consider removing attrs from the dependencies?

[[package]]

attrs = "^19.3.0"

Because the built package still includes Requires-Dist: attrs (>=19.3.0,<20.0.0).

Thanks & kind regards,

Philippe

@lomnido
Copy link
Contributor

lomnido commented Aug 13, 2024

hi Philippe,

I have been checking into this issue and found out that:

flake8-bugbear

still require 'attrs' package.
And therefore Poetry will include such dependency even if you remove it from 'pyproject.toml'
And without flake8-bugbear the Linters checks cannot be performed.
While Linters checks are NOT required to run 'tsrc', it is part of the project's code checks.

So in order to get rid of 'attrs' dependency, you need to throw away (related) checks.

This issue may require further consideration.

@philfry
Copy link
Author

philfry commented Aug 13, 2024

I see, thanks for your evaluation.

Well, at least flake8-bugbear==21.4.3 is fine with a current attrs version (24.2.0 atm) 😃

@lomnido
Copy link
Contributor

lomnido commented Aug 14, 2024

Yes, I have noticed that 'attrs' used are set to older version which is not good. We should fix that in next update.

@lomnido
Copy link
Contributor

lomnido commented Aug 14, 2024

updating project files:
bumping 'attrs' to '24.2.0' since commit:
3390907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants