Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid synchronous fs calls #107

Open
maksis opened this issue Dec 19, 2020 · 1 comment
Open

Avoid synchronous fs calls #107

maksis opened this issue Dec 19, 2020 · 1 comment

Comments

@maksis
Copy link

maksis commented Dec 19, 2020

If the disk is under unusually heavy load (or the response times are long for other reason), I'd assume that the current synchronous fs calls in is.js can cause the process event loop to be blocked for an unnecessarily long time when receiving a burst of change notifications or performing the initial directory tree scan (looks like is.directory is even called twice for each directory).

I suspect that this is currently causing timeouts in my project as the Node process isn't able to process user/socket ping requests for a few users that have their disks under heavy load (e.g. airdcpp-web/airdcpp-share-monitor#2).

@yuanchuan
Copy link
Owner

Looks like the modifications will be huge. Are you sure this is the bottle neck to airdcpp-share-monitor ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants