Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support master #27

Closed
wants to merge 1 commit into from
Closed

fix: support master #27

wants to merge 1 commit into from

Conversation

novr
Copy link
Member

@novr novr commented Jan 12, 2024

what

  • support master branch

etc

branchParsingMethodを使用者側で拡張してもいいんだけどね

swift run danger-swift ci だとassertionFailureで落ちてしまうので-c releaseで動かせばコメントはちゃんと動く

assertionFailure("Failed to get base branch")

@novr novr requested a review from a team January 12, 2024 06:37
@novr novr self-assigned this Jan 12, 2024
@el-hoshino
Copy link
Member

うーん自分は使用者側がparsingMethodを使った方がいいと思いますかな 🤔 (政治的な意味で)面倒くさいことになりそうだからあまりmasterの利用を推奨したくないので

@novr novr closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants