Skip to content

Commit 20f12ba

Browse files
committed
perf(huaweicloud): Safe*()
1 parent 89d9289 commit 20f12ba

File tree

1 file changed

+53
-23
lines changed

1 file changed

+53
-23
lines changed

internal/client/huaweicloud.go

+53-23
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,26 @@ func (hc *HuaweiCloud) Run(enabled common.Enable, ipv4, ipv6 string) (msg []stri
8484
}
8585

8686
func (hc *HuaweiCloud) getZoneId() (err error) {
87-
auth := basic.NewCredentialsBuilder().
87+
auth, err := basic.NewCredentialsBuilder().
8888
WithAk(hc.AccessKeyId).
8989
WithSk(hc.SecretAccessKey).
90-
Build()
90+
SafeBuild()
91+
if err != nil {
92+
return
93+
}
9194

92-
dnsClient := dns.NewDnsClient(
93-
dns.DnsClientBuilder().
94-
WithRegion(region.ValueOf("cn-east-3")).
95-
WithCredential(auth).
96-
Build())
95+
hr, err := region.SafeValueOf("cn-east-3")
96+
if err != nil {
97+
return
98+
}
99+
hhc, err := dns.DnsClientBuilder().
100+
WithRegion(hr).
101+
WithCredential(auth).
102+
SafeBuild()
103+
if err != nil {
104+
return
105+
}
106+
dnsClient := dns.NewDnsClient(hhc)
97107

98108
request := &model.ListPublicZonesRequest{}
99109
response, err := dnsClient.ListPublicZones(request)
@@ -112,16 +122,26 @@ func (hc *HuaweiCloud) getZoneId() (err error) {
112122
}
113123

114124
func (hc *HuaweiCloud) getParseRecord(domain, recordType string) (recordSetId, recordIP string, err error) {
115-
auth := basic.NewCredentialsBuilder().
125+
auth, err := basic.NewCredentialsBuilder().
116126
WithAk(hc.AccessKeyId).
117127
WithSk(hc.SecretAccessKey).
118-
Build()
128+
SafeBuild()
129+
if err != nil {
130+
return
131+
}
119132

120-
dnsClient := dns.NewDnsClient(
121-
dns.DnsClientBuilder().
122-
WithRegion(region.ValueOf("cn-east-3")).
123-
WithCredential(auth).
124-
Build())
133+
hr, err := region.SafeValueOf("cn-east-3")
134+
if err != nil {
135+
return
136+
}
137+
hhc, err := dns.DnsClientBuilder().
138+
WithRegion(hr).
139+
WithCredential(auth).
140+
SafeBuild()
141+
if err != nil {
142+
return
143+
}
144+
dnsClient := dns.NewDnsClient(hhc)
125145

126146
request := &model.ListRecordSetsByZoneRequest{}
127147
request.ZoneId = hc.ZoneId
@@ -145,25 +165,35 @@ func (hc *HuaweiCloud) getParseRecord(domain, recordType string) (recordSetId, r
145165
}
146166

147167
func (hc *HuaweiCloud) updateParseRecord(ipAddr, recordSetId, recordType, domain string) (err error) {
148-
auth := basic.NewCredentialsBuilder().
168+
auth, err := basic.NewCredentialsBuilder().
149169
WithAk(hc.AccessKeyId).
150170
WithSk(hc.SecretAccessKey).
151-
Build()
171+
SafeBuild()
172+
if err != nil {
173+
return
174+
}
152175

153-
dnsClient := dns.NewDnsClient(
154-
dns.DnsClientBuilder().
155-
WithRegion(region.ValueOf("cn-east-3")).
156-
WithCredential(auth).
157-
Build())
176+
hr, err := region.SafeValueOf("cn-east-3")
177+
if err != nil {
178+
return
179+
}
180+
hhc, err := dns.DnsClientBuilder().
181+
WithRegion(hr).
182+
WithCredential(auth).
183+
SafeBuild()
184+
if err != nil {
185+
return
186+
}
187+
dnsClient := dns.NewDnsClient(hhc)
158188

159189
request := &model.UpdateRecordSetRequest{}
160190
request.ZoneId = hc.ZoneId
161191
request.RecordsetId = recordSetId
162-
var listRecordsbody = []string{
192+
var listRecordsBody = []string{
163193
ipAddr,
164194
}
165195
request.Body = &model.UpdateRecordSetReq{
166-
Records: &listRecordsbody,
196+
Records: &listRecordsBody,
167197
Type: recordType,
168198
Name: domain,
169199
}

0 commit comments

Comments
 (0)