[docs]: getting_started/installation section should be fixed

[mechan1sm]

Description

The Problem

https://wiki.zshell.dev/docs/getting_started/installation
suggest the user to paste the unconditional curl execution into .zshrc

This is a bad idea due to several reasons:

1. Curl execution degrades startup time (significantly - for slow internet connections)
2. If there is no internet, curl fails and plugin manager doesn't start
3. The practice of executing the "unknown" code at zsh startup is extremely insecure.

Also, the snippet provided in "Manual Setup" section

typeset -Ag ZI
typeset -gx ZI[HOME_DIR]="${HOME}/.zi" ZI[BIN_DIR]="${ZI[HOME_DIR]}/bin"

creates the following array

ZI[HOME_DIR]=${HOME}/.zi
ZI[BIN_DIR]=/bin

instead of

ZI[HOME_DIR]=${HOME}/.zi
ZI[BIN_DIR]=${HOME}/.zi/bin

Possible solution

I think it's better to remove all the unconditional curl executions and add the following snippet

typeset -Ag ZI
ZI[HOME_DIR]="${HOME}/.zi"
ZI[BIN_DIR]="${ZI[HOME_DIR]}/bin"
[ ! -d ${ZI[BIN_DIR]} ] && mkdir -p "${ZI[BIN_DIR]}"
[ ! -d ${ZI[BIN_DIR]}/.git ] && git clone https://github.com/z-shell/zi.git "${ZI[BIN_DIR]}"
source "${ZI[BIN_DIR]}/zi.zsh"

Select the area that is associated with this issue.

ZI (this repository)

Self-service

• I'd be willing to address this documentation request myself.

Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines.

Are you familiar with the Contributor Covenant Code of Conduct?

• I have read the Contributor Covenant Code of Conduct.

Contact Details

No response

[emirkmo]

Is this still valid? Trying to make sense of the documentation.

[aidan-gibson]

This should be prioritized; they're skewering this project alive https://news.ycombinator.com/item?id=39973341

[LeoDog896]

@ss-o any news on this?

[ss-o]

Issue closed and locked due to lack of activity. If you encounter this same issue, please open a new issue and refer to this closed one.