Episode number extracted from directory name instead of filenames

[Apcty]

Current problem

When the "Take Subdirectory name into account" option is checked, some directory names used in batches will interfere with the episode numbering.
[HorribleSubs] Oshiete! Galko-chan (01-12) [1080p] (Batch)/[HorribleSubs] Oshiete! Galko-chan - 08 [1080p].mkv will correctly detect the show name but not attribute an episode number.

Suggested fix

Currently the full path is used for both name search and episode search.

anime_info = self.parser_class(self.msg, filename)
show_title = anime_info.getName()
(show_ep_start, show_ep_end) = anime_info.getEpisodeNumbers(True)

My suggestion is to use the full path for name search, and switch to filename for episode search. In my case the problem is solved with this change, but it may cause new problems for other releases.

anime_info = self.parser_class(self.msg, filename)
show_title = anime_info.getName()
ep_info = self.parser_class(self.msg, os.path.basename(filename))
(show_ep_start, show_ep_end) = ep_info.getEpisodeNumbers(True)

[molkoback]

Makes sense to me. I don't see why episode numbers should be parsed from directory names even though it goes against the logic of the option.

[FichteFoll]

Personally, I would need to see and understand more use cases of when the "Take Subdirectory name into account" is needed to make a more educated decision on anything that affects it. I do understand that for the case you provided, only taking the ep number from the file's basename will fix it, but as you mentioned there may be side effects for setups like /Series/EpNum/video.mkv, which I totally do not know whether it exists in the wild but this is how I understand the feature to work, basically.

[Apcty]

I used the "Take Subdirectory name into account" parameter because some batches are structures like /Series/EpNum - Title.mkv, and the option has affected other batches. I had not considered the cases like Series/EpNum/video.mkv being affected with this change. I agree that this needs a fallback to the current method. The suggestion is getting a bit too long for a comment so I'll just go ahead and send a small PR.