Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build using release flag --> 2x/3x performance #28

Closed
AbelVM opened this issue Apr 8, 2020 · 6 comments
Closed

Build using release flag --> 2x/3x performance #28

AbelVM opened this issue Apr 8, 2020 · 6 comments

Comments

@AbelVM
Copy link

AbelVM commented Apr 8, 2020

As mentioned at #23 (comment) , adding -DCMAKE_BUILD_TYPE=Release to the makefile results in 2x/3x improvements as per @Komzpa 's benchmarks at uber/h3#326

Current

kom@nucat:~/proj/h3/build$ bin/benchmarkH3Api 
        -- geoToH3: 1.187343 microseconds per iteration (10000 iterations)
        -- h3ToGeo: 0.796665 microseconds per iteration (10000 iterations)
        -- h3ToGeoBoundary: 2.219408 microseconds per iteration (10000 iterations)

With Release flag

kom@nucat:~/proj/h3/build$ bin/benchmarkH3Api
        -- geoToH3: 0.517386 microseconds per iteration (10000 iterations)
        -- h3ToGeo: 0.295042 microseconds per iteration (10000 iterations)
        -- h3ToGeoBoundary: 1.496694 microseconds per iteration (10000 iterations)

Latest build v3.6.2 does not use this flag

@zachasme
Copy link
Owner

zachasme commented Apr 8, 2020

I'll get right on it.

Focus for v3.6.2 was making h3index pass-by-value on supported systems.

@AbelVM
Copy link
Author

AbelVM commented Apr 8, 2020

Will it be released as a v3.6.2 hotfix or should we wait till v3.6.3? 😋

@zachasme
Copy link
Owner

zachasme commented Apr 8, 2020

I'm about to release it as v3.6.3 🚀

@AbelVM
Copy link
Author

AbelVM commented Apr 8, 2020

BOOM 💥

@Komzpa
Copy link
Contributor

Komzpa commented Apr 8, 2020

Please please check it with objdump that it all indeed inlined in final build. I had issues with it and couldn't do it for unknown for me reason.

@zachasme
Copy link
Owner

zachasme commented Apr 8, 2020

I'm going to keep your original issue open @Komzpa until we figure out how to get h3 inlined.

For now the performance improvements from release flag is worth a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants