[Host.Redis] Error logged every time while processing redi pub/sub topic #140

Signed-off-by: Tomasz Maruszak <[email protected]>

Author: zarusz

src/Host.Transport.Properties.xml

@@ -4,6 +4,6 @@
 	<Import Project="Common.Properties.xml" />
 
 	<PropertyGroup>
-		<Version>1.22.0</Version>
+		<Version>1.22.1</Version>
 	</PropertyGroup>
 </Project>

src/SlimMessageBus.Host.Redis/Consumers/RedisListCheckerConsumer.cs

@@ -49,7 +49,7 @@ public async Task Start()
             _cancellationTokenSource?.Cancel();
             _cancellationTokenSource = new CancellationTokenSource();
         }
-        _task = await Task.Factory.StartNew(() => Run(), _cancellationTokenSource.Token, TaskCreationOptions.LongRunning, TaskScheduler.Current).ConfigureAwait(false);
+        _task = await Task.Factory.StartNew(Run, _cancellationTokenSource.Token, TaskCreationOptions.LongRunning, TaskScheduler.Current).ConfigureAwait(false);
     }
 
     public async Task Stop()

src/SlimMessageBus.Host.Redis/Consumers/RedisTopicConsumer.cs

@@ -65,7 +65,11 @@ private async Task OnMessage(ChannelMessage m)
         {
             exception = e;
         }
-        _logger.LogError(exception, "Error occured while processing the redis pub/sub topic {Topic}", _topic);
+        if (exception != null)
+        {
+            // In the future offer better error handling support - retries + option to put failed messages on a DLQ.
+            _logger.LogError(exception, "Error occured while processing the redis channel {Topic}", _topic);
+        }
     }
 
     #region IAsyncDisposable