Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up and Down Variables #3

Open
gwmdunda opened this issue Jan 4, 2024 · 6 comments
Open

Up and Down Variables #3

gwmdunda opened this issue Jan 4, 2024 · 6 comments

Comments

@gwmdunda
Copy link

gwmdunda commented Jan 4, 2024

Dear Authors,

Thank you for your works. May I ask why we need up and down variables in the model?

@zbh2047
Copy link
Owner

zbh2047 commented Jan 4, 2024

Hi, thanks for your interest in our work. Here we add up and down variables in order to support the interval bound propagation in computing the certified radius for L-infinity distance layers. You may not use it if the certified radius is computed simply based on the Lipschitz property. You will need up and down variables for hybrid architectures, e.g., a MLP is built on top of an L-infinity distance net. Hope this can address your question.

@gwmdunda
Copy link
Author

gwmdunda commented Jan 5, 2024

Thank you for your answer. May I also ask why there is a negative sign in the forward() function (x, lower, upper = -x, -upper, -lower)

@zbh2047
Copy link
Owner

zbh2047 commented Jan 5, 2024

Hi, could you please provide the location of this line of code?

@gwmdunda
Copy link
Author

gwmdunda commented Jan 5, 2024

It is in ell_inf_models.py line 43

@zbh2047
Copy link
Owner

zbh2047 commented Jan 5, 2024

The model implemented in this repo follows the original ICML paper, where in Section 3.2 g(x) = (−x_1^{(L)}, −x_2^{(L)}, ..., −x_M^{(L)}). So this line of code takes negative for x, lower, upper variables.

@gwmdunda gwmdunda closed this as completed Jan 6, 2024
@gwmdunda
Copy link
Author

I am a bit confused since in ICML paper you need to take the negative sign, but in your ICLR paper, the negative sign is not needed.

@gwmdunda gwmdunda reopened this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants