Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move color configurations to own table? #166

Open
zcadditions opened this issue May 30, 2019 · 4 comments
Open

Move color configurations to own table? #166

zcadditions opened this issue May 30, 2019 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@zcadditions
Copy link
Owner

I think was a request some time ago, just can't find the issue if one was created. Any input on this?

@zcadditions zcadditions added the question Further information is requested label May 30, 2019
@zcadditions zcadditions self-assigned this May 30, 2019
@chindraba-work
Copy link
Contributor

Originally in Issue #69. Without knowing what became of the, now dead, repo it was closed in favor of I cannot guess what was learned from that effort.

If I gathered correctly from a scan of that thread, the reason in favor of a split from the configuration table is for upgrade protection. That could be solved with a tool to create an SQL script to restore current values after an upgrade.

I'm new to the development end of ZC, so my knowledge is spotty, at best. I think splitting the colors into a new table would involve re-inventing the wheel, and providing all the overhead yourself. Duplicating what's done by the core code with the configuration table. That would include having another source of potential bugs, and/or disconnect from the program flow. All in all, increasing your workload for this project without a clear and convincing need.

An additional point in favor of keeping in the main configuration table is that other templates, cloned from this one, can enhance the process without incurring additional overhead, and if/when a ZC core change implements color controls, the processing will remain the same as it is here, and as it is for all other configuration values in the core.

@zcadditions
Copy link
Owner Author

I do now remember, the collaboration never moved forward on my behalf do to my time constraints. I also shied away do to the current way the project was going, wasn't as dummy proof as I wanted it to be.

I also never included the updates I made due to what a wise one once said to me. "I don’t like plugins that use the install-then-delete method, since it makes it more difficult to migrate a test site to production."

I think at this point, to allow for more control over display without altering stylesheets, I will move forward with my version of this, to include the built-in-responsive-classic and the zca-responsive-classic template.

@chindraba-work
Copy link
Contributor

I'm guessing that the phrase plugins that use the install-then-delete method refers to something other than what YOUR_ADMIN/includes/init_includes/init_bc_config.php does to YOUR_ADMIN/includes/auto_loaders/config.bc.php. That one gave me fits when trying to clone the bootstrap template.

@zcadditions
Copy link
Owner Author

The "clone-template" plugin shouldn't effect those 2 files in any way. I use the "clone-template" regularly without hiccup.

The phrase install-then-delete method refers to adding configurations "colors", the deleting them from configuration to add them to their own table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants