Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add an in-memory wallet backend framework #1293

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Feature: Add an in-memory wallet backend framework #1293

wants to merge 26 commits into from

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Mar 20, 2024 •
edited by str4d
Loading

This sets up the general framework; most of the implementation is todo!().

Closes #1414.

@nuttycom nuttycom mentioned this pull request Mar 20, 2024
Closed
@nuttycom nuttycom marked this pull request as draft March 20, 2024 17:44
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.68067% with 117 lines in your changes are missing coverage. Please review.

Project coverage is 63.09%. Comparing base (f7c29f0) to head (fc757b1).
Report is 38 commits behind head on main.

❗ Current head fc757b1 differs from pull request most recent head 29e2043. Consider uploading reports for the commit 29e2043 to get more accurate results

Files Patch % Lines
zcash_client_backend/src/data_api/mem_wallet.rs 0.00% 115 Missing ⚠️
zcash_client_sqlite/src/lib.rs 50.00% 1 Missing ⚠️
zcash_proofs/src/circuit/sprout/input.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
- Coverage   63.23%   63.09%   -0.15%     
==========================================
  Files         124      122       -2     
  Lines       14507    14058     -449     
==========================================
- Hits         9174     8870     -304     
+ Misses       5333     5188     -145

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oxarbitrage and others added 18 commits March 20, 2024 15:51
@oxarbitrage
fix build bu hiding orchard fields in new() behind a flag
b39765c
@nuttycom
Merge pull request #1295 from oxarbitrage/memory_wallet_fix_build
fc757b1 
Fix the memory wallet build by hiding orchard fields in `new()` behind a flag
@oxarbitrage
create a very basic put_blocks function for the memory wallet
69c1e68
@oxarbitrage
Merge remote-tracking branch 'origin/memory_wallet_db' into memory_wa…
09e8bc9 
…llet_fix_build
@oxarbitrage
append sapling noie commitments to database
9c0c6b0
@oxarbitrage
remove non needed pubs
4d3c441
@oxarbitrage
remove chain_height code
7f74621
@oxarbitrage
add orchard spends
0393a69
@oxarbitrage
add sapling and orchard trees
a4323c2
@oxarbitrage
use sapling-crypto v0.1.3
a3b4de0
@oxarbitrage
populate orchard note commitment trees
370a4aa
@oxarbitrage
use batch_insert
b1a0fcc
@oxarbitrage
add the memos
23a2ae8
@oxarbitrage
mark spent notes
2f28306
@oxarbitrage
fix note commitment tree starting position
588156f
@oxarbitrage
use all accounts in the wallet
f77dfc1
@oxarbitrage
remove todo comment
147c033
@oxarbitrage @nuttycom
fix incorrect start note commitment position
cbb49b4 
Co-authored-by: Kris Nuttycombe <[email protected]>
@oxarbitrage oxarbitrage mentioned this pull request Apr 16, 2024
Closed
@oxarbitrage oxarbitrage mentioned this pull request Apr 16, 2024
Merged
@oxarbitrage
Copy link
Contributor

I think it can be a good to create a list of the minimal requirements we consider needed to merge this PR while leave the rest of the functions to make individual pull requests against the main repo ?

@str4d str4d changed the title Feature: Add an in-memory wallet backend. Feature: Add an in-memory wallet backend framework Jun 13, 2024
@str4d
Copy link
Contributor

str4d commented Jun 13, 2024

Per the meeting today, this PR needs to be rebased on main and squashed down. Then once we're happy with it as a framework, we can merge it, and then implement its internals by migrating tests over (#1415) after the test framework has been migrated {#1412).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zcash_client_backend: Create the framework for an in-memory wallet backend
3 participants
@nuttycom @oxarbitrage @str4d