refactor: enable ninja colorful output as macro of rocbuild.cmake

zchrissirhcz · Nov 22, 2024 · 737adfc · 737adfc
1 parent a8e40e2
commit 737adfc
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 24 deletions.
diff --git a/ninja_colorful_output.cmake b/ninja_colorful_output.cmake
@@ -3,15 +3,3 @@
 # Last update: 2024-05-26 23:30:00
 cmake_minimum_required(VERSION 3.15)
 include_guard()
-
-# When building a CMake-based project, Ninja may speedup the building speed, comparing to Make.
-# However, with `-GNinja` specified, compile errors are with no obvious colors.
-# This cmake plugin just solve this mentioned problem, giving colorful output for Ninja.
-## References: https://medium.com/@alasher/colored-c-compiler-output-with-ninja-clang-gcc-10bfe7f2b949
-
-add_compile_options(
-  "$<$<COMPILE_LANG_AND_ID:CXX,GNU>:-fdiagnostics-color=always>"
-  "$<$<COMPILE_LANG_AND_ID:CXX,Clang,AppleClang>:-fcolor-diagnostics>"
-  "$<$<COMPILE_LANG_AND_ID:C,GNU>:-fdiagnostics-color=always>"
-  "$<$<COMPILE_LANG_AND_ID:C,Clang,AppleClang>:-fcolor-diagnostics>"
-)
diff --git a/rocbuild.cmake b/rocbuild.cmake
@@ -32,4 +32,19 @@ macro(rocbuild_set_artifacts_path)
 endmacro()
 
 
-rocbuild_set_artifacts_path()
+macro(rocbuild_enable_ninja_colorful_output)  
+  # When building a CMake-based project, Ninja may speedup the building speed, comparing to Make.
+  # However, with `-GNinja` specified, compile errors are with no obvious colors.
+  # This cmake plugin just solve this mentioned problem, giving colorful output for Ninja.
+  ## References: https://medium.com/@alasher/colored-c-compiler-output-with-ninja-clang-gcc-10bfe7f2b949
+  add_compile_options(
+    "$<$<COMPILE_LANG_AND_ID:CXX,GNU>:-fdiagnostics-color=always>"
+    "$<$<COMPILE_LANG_AND_ID:CXX,Clang,AppleClang>:-fcolor-diagnostics>"
+    "$<$<COMPILE_LANG_AND_ID:C,GNU>:-fdiagnostics-color=always>"
+    "$<$<COMPILE_LANG_AND_ID:C,Clang,AppleClang>:-fcolor-diagnostics>"
+  )
+endmacro()
+
+
+rocbuild_set_artifacts_path()
+rocbuild_enable_ninja_colorful_output()
diff --git a/test/ninja_colorful_output/CMakeLists.txt b/test/ninja_colorful_output/CMakeLists.txt
diff --git a/test/ninja_colorful_output/test.cpp b/test/ninja_colorful_output/test.cpp