Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vim] r and shift-r undo error,r count error #13566

Closed
1 task done
0x2CA opened this issue Jun 27, 2024 · 1 comment
Closed
1 task done

[vim] r and shift-r undo error,r count error #13566

0x2CA opened this issue Jun 27, 2024 · 1 comment
Labels
defect [core label] keymap / key binding Feedback for keyboard shortcuts, key mapping, etc vim

Comments

@0x2CA
Copy link
Contributor

0x2CA commented Jun 27, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Undo Error

2024-06-25.10.09.04.mov

r should not generate characters, because r is just a single character replacement, and the original length should be whatever the maximum should be.When the count exceeds the current character, you should do nothing.shift-r allows generating characters that are longer than the original characters

2024-06-25.10.10.16.mov

Originally posted by @0x2CA in #13287 (comment)

Environment

Zed: v0.142.1 (Zed Preview)
OS: macOS 14.5.0
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Zed.log
@0x2CA 0x2CA added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jun 27, 2024
@notpeter notpeter added vim keymap / key binding Feedback for keyboard shortcuts, key mapping, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jun 27, 2024
ConradIrwin added a commit that referenced this issue Jun 28, 2024
ConradIrwin added a commit that referenced this issue Jun 28, 2024
Release Notes:

- vim: Fix undo after repeated insert/replace mode (#13573)
- vim: Fix 'r' repeating too much (#13566)
@ConradIrwin
Copy link
Collaborator

Fixed by #13623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] keymap / key binding Feedback for keyboard shortcuts, key mapping, etc vim
Projects
None yet
Development

No branches or pull requests

3 participants