Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows?] Hue shift on semi-transparent layers #16713

Open
1 task done
Huliiiiii opened this issue Aug 23, 2024 · 2 comments
Open
1 task done

[Windows?] Hue shift on semi-transparent layers #16713

Huliiiiii opened this issue Aug 23, 2024 · 2 comments
Labels
accessibility Improvement related to color contrast, screen reader support, keyboard navigation, etc bug [core label] theme Feedback for theme configuration, accessibility, visual issues, etc windows

Comments

@Huliiiiii
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

VsCode:
image
image
image

Zed:
image
image
image

We can notice that on Zed, the hue of semi-transparent layers is skewed towards the higher value color, and this shouldn't happen.

Environment

Zed: v0.151.0 (Zed Dev 2856842)
OS: Windows 10.0.22631
Memory: 31.9 GiB
Architecture: x86_64
GPU: NVIDIA GeForce RTX 2060 || NVIDIA || 556.12

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
@Huliiiiii Huliiiiii added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Aug 23, 2024
@JunkuiZhang
Copy link
Contributor

It seems that the Blade rendering backend has some color issues on Windows. I tested your #0080ff80 example using the One Light theme, and here’s what I observed:

The DX11 backend is very close to the macOS results, whereas both differ noticeably from Blade.

@apricotbucket28
Copy link
Contributor

apricotbucket28 commented Aug 25, 2024

This is because the Blade backend uses Linear instead of sRGB:

@Moshyfawn Moshyfawn added windows theme Feedback for theme configuration, accessibility, visual issues, etc accessibility Improvement related to color contrast, screen reader support, keyboard navigation, etc and removed triage Maintainer needs to classify the issue labels Aug 28, 2024
@JosephTLyons JosephTLyons added accessibility Improvement related to color contrast, screen reader support, keyboard navigation, etc and removed accessibility Improvement related to color contrast, screen reader support, keyboard navigation, etc admin read Pending admin review labels Aug 30, 2024
@github-actions github-actions bot added admin read Pending admin review triage Maintainer needs to classify the issue labels Nov 5, 2024
@notpeter notpeter removed triage Maintainer needs to classify the issue admin read Pending admin review labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Improvement related to color contrast, screen reader support, keyboard navigation, etc bug [core label] theme Feedback for theme configuration, accessibility, visual issues, etc windows
Projects
None yet
Development

No branches or pull requests

6 participants