Prek causes git commit to never complete

[WAKayser]

Summary

Prek (alternative to pre-commit) causes git commit to never complete and prevents various features from working.

Description

Recently I tried switching from pre-commit to prek. All seemed to work well. But when committing from zed the commit spinner keeps spinning infinitely. This also prevents any other update to git state or the agent panel from working.

Steps to reproduce:

1. create git repo
2. install prek (uv tool install prek && prek install)
3. add a sample .pre-commit-config.yaml file.
4. try to create a commit via the panel.

Sample file to use.

repos:
  - repo: local
    hooks:
      - id: test
        name: test
        entry: echo "Running tests..."
        language: system
        pass_filenames: false

fail_fast: true

Expected Behavior:
commit to succeed.

Actual Behavior:
git commit spinner keeps showing in the bottom bar.

Nothing on this shows in the log and there is no error message. I have set up zed to be build. Let me know what I can do to help troubleshoot this issue.

Zed Version and System Specs

Zed: v0.201.8 (Zed)
OS: macOS 15.5.0
Memory: 18 GiB
Architecture: aarch64

[j178]

This isn't just a prek sepcific issue, I can make a minimal reproducer:

$ cargo init zed-reproducer
$ cd zed-reproducer
$ cargo add tokio -F full

Edit src/main.rs:

use tokio::process::Command;

#[tokio::main]
async fn main() {
    let output = Command::new("git").arg("version").output().await.unwrap();
    println!("{}", String::from_utf8_lossy(&output.stdout));
}

$ cargo build
$ cp ./target/debug/zed-reproducer .git/hooks/pre-commit

Open this project in Zed, and commit in Git Panel, then the commit hangs.

Edit: This seems to only reproduce on macOS and with tokio async runtime.

[leoliu0605]

I'd like to work on this!

[esthertrapadoux]

Woohoo!!!!! Assigned this to you @leoliu0605 !

[leoliu0605]

Hi @esthertrapadoux , I found that this issue was resolved by this commit change: 359160c#diff-b9f33286c41e01537d8a3bd83987cf838f75ed2432074d0bc114a6dc33726f42

The key point is self.executor.spawn hanging while waiting for SIGCHLD like these issue mentioned: j178/prek#756 and tokio-rs/tokio#6953

Once use async instead of spawn, it work well:

+++ b/crates/git/src/repository.rs
@@ -1634,8 +1634,7 @@ impl GitRepository for RealGitRepository {
     ) -> BoxFuture<'_, Result<()>> {
         let working_directory = self.working_directory();
         let git_binary_path = self.any_git_binary_path.clone();
-        self.executor
-            .spawn(async move {
+        async move {
                 let mut cmd = new_smol_command(git_binary_path);
                 cmd.current_dir(&working_directory?)
                     .envs(env.iter())
@@ -1663,7 +1662,7 @@ impl GitRepository for RealGitRepository {
                     String::from_utf8_lossy(&output.stderr)
                 );
                 Ok(())
-            })
+            }
             .boxed()
     }

cc @cole-miller

[esthertrapadoux]

@leoliu0605 thanks for tracking this down!!

@cole-miller should we close the issue?

[cole-miller]

Closing as fixed.